summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* bgpd: remove VERSION_TYPE_DEV from CONFDATE checksLou Berger2018-07-102-5/+5
| | | | Signed-off-by: Lou Berger <lberger@labn.net>
* lib: remove VERSION_TYPE_DEV from CONFDATE checksLou Berger2018-07-104-5/+5
| | | | Signed-off-by: Lou Berger <lberger@labn.net>
* doc: update doc to no longer requires use of VERSION_TYPE_DEVLou Berger2018-07-101-1/+1
| | | | Signed-off-by: Lou Berger <lberger@labn.net>
* *: VERSION_TYPE no longer needed -- remove itLou Berger2018-07-101-2/+1
| | | | Signed-off-by: Lou Berger <lberger@labn.net>
* *: ignore deprecated code statments in release versionsLou Berger2018-07-101-1/+7
| | | | | | by setting CONFDATE to 0 Signed-off-by: Lou Berger <lberger@labn.net>
* Merge pull request #2553 from opensourcerouting/release_procQuentin Young2018-07-102-0/+87
|\ | | | | doc: Add document for Release Build by maintainer
| * doc: Add document for Release Build by maintainerMartin Winter2018-07-102-0/+87
| | | | | | | | Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
* | Merge pull request #2643 from qlyoung/doc-workflow-reviewsRenato Westphal2018-07-101-0/+31
|\ \ | | | | | | doc: add dev docs on code review practices
| * | doc: add dev docs on code review practicesQuentin Young2018-07-091-0/+31
| | | | | | | | | | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* | | Merge pull request #2636 from ppmathis/cleanup/bgpdQuentin Young2018-07-0921-251/+20
|\ \ \ | | | | | | | | bgpd: Cleanup of bgp daemon code
| * | | bgpd: Cleanup of bgp daemon codePascal Mathis2018-07-0721-251/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit removes various parts of the bgpd implementation code which are unused/useless, e.g. unused functions, unused variable initializations, unused structs, ... Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
* | | | Merge pull request #2637 from donaldsharp/pim_malloc_meRenato Westphal2018-07-0916-224/+2
|\ \ \ \ | |_|/ / |/| | | pimd: Remove unnecessary alloc failures
| * | | pimd: Remove unnecessary alloc failuresDonald Sharp2018-07-0816-224/+2
| |/ / | | | | | | | | | | | | | | | | | | Remove from pim unnecessary alloc failure testing as that alloc failure will cause an assert. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | | Merge pull request #2642 from donaldsharp/deprecatedRenato Westphal2018-07-091-23/+0
|\ \ \ | | | | | | | | ospfd: Remove deprecated code
| * | | ospfd: Remove deprecated codeDonald Sharp2018-07-091-23/+0
| |/ / | | | | | | | | | | | | | | | This code has been deprecated for over a year, let's remove it now. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | | Merge pull request #2632 from ppmathis/bugfix/bgp-autoshutQuentin Young2018-07-091-4/+10
|\ \ \ | |/ / |/| | bgpd: Fix bgp auto-shutdown behavior
| * | bgpd: Fix bgp auto-shutdown behaviorPascal Mathis2018-07-071-4/+10
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current behavior of the `bgp default shutdown` command is to set the state of all newly configured peers to shutdown. This leads to a problem when restarting bgpd, because all peers will then be seen as newly configured, which leads to all peers being set to shutdown after each restart. This behavior is undesired and not common when comparing the implementation against other vendors. This commit moves the `bgp default shutdown` configuration underneath the peer-group and peer configuration, to ensure that existing peers will not be set to shutdown after a daemon restart. Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
* | Merge pull request #2630 from donaldsharp/hashablesRafael Zalamena2018-07-062-13/+7
|\ \ | | | | | | revert hash_walk/iterate optimizations
| * | vtysh: Remove unused variableDonald Sharp2018-07-061-1/+0
| | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
| * | lib: Add some documentationDonald Sharp2018-07-061-2/+6
| | | | | | | | | | | | | | | | | | | | | Add some documentation to hash_walk/iterate to tell people to not do something stupid. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
| * | Revert "lib: A small optimization for the hash iterate and walk functions"Donald Sharp2018-07-062-11/+2
| | | | | | | | | | | | This reverts commit fc61644e440c875eefa222ab34d726c6281ca806.
* | | Merge pull request #2628 from pguibert6WIND/realpath_debugQuentin Young2018-07-061-2/+5
|\ \ \ | | | | | | | | lib: add the pathname to get the realpath in case of failure
| * | | lib: add the pathname to get the realpath in case of failurePhilippe Guibert2018-07-061-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sometimes, the file under /var/run/netns may not be authorised to be read ( because it is not read permission for frr user, for instance). so it is good to know what happened. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
* | | | Merge pull request #2618 from pacovn/PVS-Studio_library_warningsQuentin Young2018-07-061-22/+27
|\ \ \ \ | | | | | | | | | | pimd: standard library usage (PVS-Studio)
| * | | | pimd: standard library usage (PVS-Studio)F. Aragon2018-07-061-22/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fread() function was not used properly. Signed-off-by: F. Aragon <paco@voltanet.io>
* | | | | Merge pull request #2605 from pacovn/PVS-Studio_null_checkJafar Al-Gharaibeh2018-07-062-2/+7
|\ \ \ \ \ | |_|_|/ / |/| | | | ospfd pimd: null check (PVS-Studio)
| * | | | ospfd pimd: null check (PVS-Studio)F. Aragon2018-07-062-2/+7
|/ / / / | | | | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | | | Merge pull request #2602 from pacovn/PVS-Studio_element_overflowQuentin Young2018-07-056-7/+7
|\ \ \ \ | | | | | | | | | | bgpd zebra: element overflow (PVS-Studio)
| * | | | bgpd zebra: element overflow (PVS-Studio)F. Aragon2018-07-026-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The warning given by PVS-Studio is related to per-element overflow (there is no real overflow, because of how elements are mapped in the union). This same warning is typically reported by Coverity, too. Signed-off-by: F. Aragon <paco@voltanet.io>
* | | | | Merge pull request #2623 from pacovn/PVS-Studio_memcpy_source_underflowQuentin Young2018-07-056-51/+46
|\ \ \ \ \ | | | | | | | | | | | | ldpd: buffer underflow, thread safety (PVS-Studio)
| * | | | | ldpd: buffer underflow, thread safety (PVS-Studio)F. Aragon2018-07-046-51/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit fixes two issues: - memcpy() using containers of different sizes when using addr2sa(), mixing 'struct sockaddr_storage' and 'union sockunion'. - addr2sa() function not being thread safe (using a local static variable as container. Signed-off-by: F. Aragon <paco@voltanet.io>
* | | | | | Merge pull request #2568 from pguibert6WIND/doc_mplsQuentin Young2018-07-051-0/+88
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | doc: add MPLS configuration commands
| * | | | | doc: add MPLS configuration commandsPhilippe Guibert2018-07-041-0/+88
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | Add MPLS information to statically handle label from zebra. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
* | | | | Merge pull request #2624 from donaldsharp/PIM_ZOMILY_ZOMJafar Al-Gharaibeh2018-07-051-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | pimd: Use generated interface name
| * | | | pimd: Use generated interface nameDonald Sharp2018-07-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we have a generated interface name, use it instead of the actual pointer. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | | | | Merge pull request #2614 from rtrlib/2018-07-02-master-bugfixDonald Sharp2018-07-041-4/+10
|\ \ \ \ \ | | | | | | | | | | | | bgpd: fix rpki validation for ipv6 (master)
| * | | | | bgpd: fix rpki validation for ipv6Marcel Röthke2018-07-031-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
* | | | | | Merge pull request #2620 from pacovn/PVS-Studio_null_check_2Quentin Young2018-07-0311-30/+42
|\ \ \ \ \ \ | | | | | | | | | | | | | | bgpd lib ospfd pimd ripngd: null chk (PVS-Studio)
| * | | | | | bgpd lib ospfd pimd ripngd: null chk (PVS-Studio)F. Aragon2018-07-0311-30/+42
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | | | | | Merge pull request #2610 from qlyoung/fix-zebra-pthread-crash-shutdown-minJafar Al-Gharaibeh2018-07-031-8/+0
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | zebra: remove asserts on task nullity
| * | | | | zebra: remove asserts on task nullityQuentin Young2018-07-021-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While ZAPI I/O threads make a best effort to kill any scheduled tasks on their threadmasters, after death another pthread can continue to schedule onto the threadmaster. This isn't a problem per se since the tasks will never run, but it also means that asserting that it hasn't happened is pointless. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* | | | | | Merge pull request #2619 from pguibert6WIND/show_ipv6_bgp_wrongJafar Al-Gharaibeh2018-07-031-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | doc: bgp wrong command displayed
| * | | | | | doc: bgp wrong command displayedPhilippe Guibert2018-07-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This command does not exist. Move it to the right one. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
* | | | | | | Merge pull request #2615 from chiragshah6/evpn_devLou Berger2018-07-031-5/+6
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | bgpd: l3vni del to free ip prefix routes from vrf
| * | | | | | | bgpd: l3vni del to free ip prefix routes from vrfChirag Shah2018-07-021-5/+6
| | |_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Symmetric routing case, L3VNI stores evpn MAC_IP routes as IP_PREFIX routes in associated bgp_vrf and fib. When vxlan device for l3vni goes down, triggers l3vni delete in bgp. As part l3vni delete, evpn ip prefix routes associated with the vni need to be withdrawn from zebra as well bgpinfo needs to be freed. bgp_delete does not free bgp_info associated to evpn ip prefix routes (link to bgp_vrf). Call to uninstall_evpn_route_entry_in_vrf() properly cleanup bgp_info as well triggers appropriate updates. Ticket:CM-21443 Testing Done: On DUT, bringup symmetric routing configuration, learn EVPN Type-2 and Type-3 Routes. Type-2 MAC_IP routes will be stored as ip_prefix in vrf table during l3vni bring up. Remove L3vni, deletes all ip_prefix routes from the zebra, kernel vrf route table and bgp_info is freed. Check the show bgp memory stats for bgp_info post l3vni flap. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
* | | | | | | doc: clean up flowspec.rstQuentin Young2018-07-031-74/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix broken citations * Remove trailing whitespace * Rewrap to 80 lines * Tweak capitalization of section headers * Clean up a few indented blocks Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* | | | | | | Merge pull request #2598 from dslicenc/cm21429-vrf-dupLou Berger2018-07-031-8/+0
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | zebra: duplicate nexthops for cross-vrf static routes on vrf bounce
| * | | | | | | zebra: duplicate nexthops for cross-vrf static routes on vrf bounceDon Slice2018-07-021-8/+0
| | |_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem created by the fix for cm-21306 (inactive cross-vrf static routes when vrfs were bounced.) Determined that in another case, that fix would cause duplicate nexthops to appear in the table. Resolved the problem by removing the vrf static route process from the zebra "add" process leaving it in the zebra " if up" process as added in cm-21306 since that's the point that the vrf device is now functional. Ticket: CM-21429 Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
* | | | | | | Merge pull request #2599 from pacovn/PVS-Studio_Array_overrunLou Berger2018-07-032-3/+3
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | ospfd zebra: array overrun fixes (PVS-Studio)
| * | | | | | ospfd zebra: array overrun fixes (PVS-Studio)F. Aragon2018-07-032-3/+3
| |/ / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-12 09:07:21 +0100