summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* *: require semicolon after FRR_DAEMON_INFO & co.David Lamparter2021-03-1746-54/+89
| | | | | | ... again ... Signed-off-by: David Lamparter <equinox@diac24.net>
* *: require semicolon after DEFINE_<typesafe...>David Lamparter2021-03-1744-131/+141
| | | | | | Again, see previous commits. Signed-off-by: David Lamparter <equinox@diac24.net>
* *: require semicolon after DEFINE_QOBJ & co.David Lamparter2021-03-1740-97/+100
| | | | | | Again, see previous commits. Signed-off-by: David Lamparter <equinox@diac24.net>
* *: require semicolon after DEFINE_HOOK & co.David Lamparter2021-03-1764-132/+137
| | | | | | See previous commit. Signed-off-by: David Lamparter <equinox@diac24.net>
* *: require semicolon after DEFINE_MTYPE & coDavid Lamparter2021-03-17176-853/+859
| | | | | | | | | | | | | | | | | Back when I put this together in 2015, ISO C11 was still reasonably new and we couldn't require it just yet. Without ISO C11, there is no "good" way (only bad hacks) to require a semicolon after a macro that ends with a function definition. And if you added one anyway, you'd get "spurious semicolon" warnings on some compilers... With C11, `_Static_assert()` at the end of a macro will make it so that the semicolon is properly required, consumed, and not warned about. Consistently requiring semicolons after "file-level" macros matches Linux kernel coding style and helps some editors against mis-syntax'ing these macros. Signed-off-by: David Lamparter <equinox@diac24.net>
* *: require ISO C11 (or C++11)David Lamparter2021-03-178-74/+16
| | | | | | It's 2021... time to drop some 10yo compat stuff. Signed-off-by: David Lamparter <equinox@diac24.net>
* snmp: change -std=gnu99 to -std=gnu11David Lamparter2021-03-178-8/+8
| | | | | | | The point of the `-std=gnu99` was to override a `-std=c99` that may be coming in from net-snmp. However, we want C11, not C99. Signed-off-by: David Lamparter <equinox@diac24.net>
* Merge pull request #8258 from volta-networks/feat_ldp_snmp_with_statsDonald Sharp2021-03-165-4/+309
|\ | | | | ldpd: Add support for the read-only snmp mib objects that are statistics
| * tests: update LDP SNMP topotest to walk mib objects that are statisticsKaren Schoener2021-03-161-0/+48
| | | | | | | | Signed-off-by: Karen Schoener <karen@voltanet.io>
| * ldpd: Add support for the read-only snmp mib objects that are statisticsKaren Schoener2021-03-164-4/+261
| | | | | | | | | | | | | | | | Add support for the read-only snmp mib objects as described in RFC 3815 that are statistics. Signed-off-by: Lynne Morrison <lynne@voltanet.io> Signed-off-by: Karen Schoener <karen@voltanet.io>
* | Merge pull request #8268 from mjstapp/doc_dev_topo_notesDonald Sharp2021-03-164-7/+16
|\ \ | | | | | | doc: add info to topotest dev doc
| * | doc: add more notes about new topotestsMark Stapp2021-03-162-5/+14
| | | | | | | | | | | | | | | | | | | | | | | | Add some extra notes to the dev doc section about writing new topotests: check for OS/kernel support if necessary; avoid volatile or unstable data like ifindices or link-locals. Signed-off-by: Mark Stapp <mjs@voltanet.io>
| * | doc: fix warnings in dev docsMark Stapp2021-03-162-2/+2
| |/ | | | | | | | | | | Fix a couple of warnings in dev doc rst files. Signed-off-by: Mark Stapp <mjs@voltanet.io>
* | Merge pull request #8270 from volta-networks/fix_isis_snmp_coverityDonald Sharp2021-03-161-11/+11
|\ \ | | | | | | isisd: Fix coverity warnings
| * | isisd: Fix coverity warningslynne2021-03-161-11/+11
| | | | | | | | | | | | Signed-off-by: Lynne Morrison <lynne@voltanet.io>
* | | Merge pull request #8266 from idryzhov/eigrp-cli-fixesDonald Sharp2021-03-161-14/+13
|\ \ \ | | | | | | | | eigrp cli fixes
| * | | eigrpd: fix dependency on operational state in cliIgor Ryzhov2021-03-161-12/+11
| | | | | | | | | | | | | | | | Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
| * | | eigrpd: fix xpathsIgor Ryzhov2021-03-161-2/+2
| | |/ | |/| | | | | | | Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
* | | Merge pull request #7963 from volta-networks/feat_pceplib_into_frr_githubDonald Sharp2021-03-16127-211/+27102
|\ \ \ | | | | | | | | pceplib: Integrate pcelib into frr
| * | | pceplib: Integrate pcelib into frrJavier Garcia2021-03-05127-211/+27102
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Brady Johnson <brady@voltanet.io> Co-authored-by: Javier Garcia <javier.garcia@voltanet.io> Signed-off-by: Javier Garcia <javier.garcia@voltanet.io>
* | | | Merge pull request #8155 from idryzhov/zebra-support-bundleDonald Sharp2021-03-161-1/+2
|\ \ \ \ | |_|_|/ |/| | | zebra support bundle fixes and improvements
| * | | tools: add "show ip/ipv6 route" to zebra support bundle commandsIgor Ryzhov2021-02-261-0/+2
| | | | | | | | | | | | | | | | Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
| * | | tools: fix zebra support bundle commandsIgor Ryzhov2021-02-261-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CI constantly fails to execute "show zebra fpm stats": ``` Execute: show zebra fpm stats Traceback (most recent call last): File "/usr/lib/frr/generate_support_bundle.py", line 55, in executeCommand cmd_output = subprocess.check_output(cmd_exec_str, shell=True) File "/usr/lib/python3.6/subprocess.py", line 356, in check_output **kwargs).stdout File "/usr/lib/python3.6/subprocess.py", line 438, in run output=stdout, stderr=stderr) subprocess.CalledProcessError: Command 'vtysh -c "show zebra fpm stats" ' returned non-zero exit status 1. ``` Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
* | | | Merge pull request #7993 from mjstapp/reorg_resolveStephen Worley2021-03-162-68/+121
|\ \ \ \ | | | | | | | | | | zebra: reorg nexthop resolution code
| * | | | zebra: support nh resolution without a routeMark Stapp2021-02-192-68/+121
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Start reorg of zebra nexthop-resolution so that we can use the resolution logic for nexthop-groups as well as routes. Change the signature of the core nexthop_active() api so that it does not require a route-entry or route-node. Move some of the logic around so that nexthop-specific logic is in nexthop_active(), while route-oriented logic is in nexthop_active_check(). Signed-off-by: Mark Stapp <mjs@voltanet.io>
* | | | | Merge pull request #8226 from adharkar/frr-evi_rxPatrick Ruddy2021-03-163-1/+43
|\ \ \ \ \ | |_|_|_|/ |/| | | | bgpd: Reevaluate es_evi_vtep active state on disable-ead-evi-rx config flap
| * | | | bgpd: Reevaluate es_evi_vtep active state on disable-ead-evi-rx config flapAmeya Dharkar2021-03-103-1/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update es_evi_vtep active state and add/delete es_vtep accordingly to zebra for remote ES. Signed-off-by: Ameya Dharkar <adharkar@vmware.com>
* | | | | Merge pull request #8260 from volta-networks/fix_isis_snmp_testIgor Ryzhov2021-03-166-14/+0
|\ \ \ \ \ | | | | | | | | | | | | test: fix isis-snmp test
| * | | | | test: fix isis-snmp testlynne2021-03-166-14/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove ifindex values being tested because it can change between runs of the test. Signed-off-by: Lynne Morrison <lynne@voltanet.io>
* | | | | | Merge pull request #8214 from chiragshah6/mdevDonatas Abraitis2021-03-161-2/+9
|\ \ \ \ \ \ | | | | | | | | | | | | | | tools: frr-reload refine error handling
| * | | | | | tools: frr-reload capture vtysh msg upon failureChirag Shah2021-03-081-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Log vtysh message for a failed command. Ticket:2556706 Reviewed By: Testing Done: frr reload fails to delete default bgp instance in presence of bgp vrf instance(s), it captures vtysh message and logs in frr-reload.log logs backend 2021-03-05 05:16:45,623 INFO: Failed to execute no router bgp 5544 2021-03-05 05:16:45,735 INFO: Failed to execute no router bgp 2021-03-05 05:16:45,846 INFO: Failed to execute no router 2021-03-05 05:16:45,846 ERROR: "no router" we failed to remove this command 2021-03-05 05:16:45,847 ERROR: % Cannot delete default BGP instance. Dependent VRF instances exist Signed-off-by: Chirag Shah <chirag@nvidia.com>
| * | | | | | tools: Mark reload failure when no form cli failsChirag Shah2021-03-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if no form of the cli fails to execute, mark frr-reload as failure so return code can be nonzero. The similar approach is done for non no-form (add case) of the cli. Ticket:CM-33345 Reviewed By:CCR-11287 Testing Done: Signed-off-by: Chirag Shah <chirag@nvidia.com>
* | | | | | | Merge pull request #8254 from donaldsharp/various_fixesDavid Lamparter2021-03-162-13/+21
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | |
| * | | | | | pimd: Fix clang issue with -Waddress-of-packed-memberDonald Sharp2021-03-151-9/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Recent change in commit: 6b73800ba27e7f69453a191dfb873c2e07194516 Caused this error to pop up in pim_igmp_mtrace.c: error: taking address of packed member 'rsp_addr' of class or structure 'igmp_mtrace' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member] Follow the pattern used in the code to solve this problem for clang Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | | bgpd: use appropriate printf formatter for some uint32_tDonald Sharp2021-03-151-4/+4
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | newm and existm are uint32_t so let's use %u instead of %d to print them out. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | | | | Merge pull request #8234 from reubendowle/fixes/nhrp-trafic-indicationDonald Sharp2021-03-151-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | nhrpd: Set hop count to 1 in traffic indication
| * | | | | | nhrpd: Set hop count to 1 in traffic indicationGaurav Goyal2021-03-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If hop count is 0, this causes Cisco routers to reject the traffic indication as invalid. This appears to be a Cisco bug, and has been observed in processing of registration packets in the past. That problem was covered in issue #951 Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
* | | | | | | Merge pull request #8230 from donaldsharp/flex_moreMark Stapp2021-03-1524-657/+309
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | more switchover to using our builtin printf functionality
| * | | | | | | *: remove remaining severity prefixesDavid Lamparter2021-03-143-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Having a "warning:" prefix on a debug message is particularly dumb... Signed-off-by: David Lamparter <equinox@diac24.net>
| * | | | | | | zebra: move up prefix2str call in rib dumpDavid Lamparter2021-03-141-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: David Lamparter <equinox@diac24.net>
| * | | | | | | zebra: use printfrr exts in EVPN/VXLAN codeDavid Lamparter2021-03-147-467/+213
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: David Lamparter <equinox@diac24.net>
| * | | | | | | fpm: use printfrr extsDavid Lamparter2021-03-142-11/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: David Lamparter <equinox@diac24.net>
| * | | | | | | *: fix printf extension typesDavid Lamparter2021-03-144-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some mistakes have crept in again. Signed-off-by: David Lamparter <equinox@diac24.net>
| * | | | | | | lib: Convert to builtin printf functionalityDonald Sharp2021-03-142-17/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | | | ospf6d: Convert to use builtin printf functionalityDonald Sharp2021-03-142-54/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | | | eigrpd: Convert to using our builtin printf stuffDonald Sharp2021-03-142-12/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | | | pimd: Use builtin printf functionalityDonald Sharp2021-03-142-63/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | | | babeld: We do not need to put Warning into our warning messagesDonald Sharp2021-03-143-15/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | | | sharpd: Convert over to using builtin printf functionalityDonald Sharp2021-03-141-11/+6
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | | | | | Merge pull request #8220 from mjstapp/bgp_notify_raceDonatas Abraitis2021-03-153-27/+58
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | bgpd: handle socket read errors in the main pthread
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-17 02:00:58 +0100