summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | debian: fix texinfo figure installation directoryDavid Lamparter2023-01-242-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As pointed out by lintian. Signed-off-by: David Lamparter <equinox@opensourcerouting.org> (cherry picked from commit b62f9af6b6716174c1510cc5160b11a40f37d6c0)
| * | | | | debian: fix sphinx docsDavid Lamparter2023-01-242-10/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - use dh_sphinxdoc to get rid of embedded JS Signed-off-by: David Lamparter <equinox@opensourcerouting.org> (cherry picked from commit e1e2ea84eed7f1880e1ed3fa2cfa09eaa9d2cdc1)
| * | | | | debian: fix cross-build marks (libelf/libpython3)David Lamparter2023-01-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These two build-deps are for compile-time tools and thus need to be marked :native. Signed-off-by: David Lamparter <equinox@opensourcerouting.org> (cherry picked from commit e9f0af06c90df7a8364534e2b2e5225ece00076f)
| * | | | | debian: make cross-compile workDavid Lamparter2023-01-244-25/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows e.g. "sbuild --host=arm64" to build packages for other architectures on, say, fat amd64 servers. As a side effect, the Debian build uses a separate builddir, which helps noting issues on that front. Signed-off-by: David Lamparter <equinox@diac24.net> (cherry-picked from commit d1312e009b62331d39d0b9e77997b2f42be66f46)
* | | | | | Merge pull request #12717 from opensourcerouting/topotest_stop_topo_fixDonald Sharp2023-01-314-4/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | tests: Fix wrong tgen.stop_topology() calls which got skipped
| * | | | | | tests: Fix wrong tgen.stop_topology() calls which got skippedMartin Winter2023-01-314-4/+4
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Calls were missing the () and caused the stop_topology() to be skipped Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
* | | | | | Merge pull request #12687 from opensourcerouting/build-mkdir-pMark Stapp2023-01-315-4/+8
|\ \ \ \ \ \ | | |/ / / / | |/| | | | build: consistently mkdir -p output for redirect
| * | | | | yang: fix race condition in embedmodel.py mkdirDavid Lamparter2023-01-241-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Parallel build may be executing another copy of embedmodel.py at the same time, with both getting "False" on the isdir check, and then both trying to mkdir - one of which will error out. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
| * | | | | build: consistently mkdir -p output for redirectDavid Lamparter2023-01-244-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When running the build in a separate build directory, redirecting output into a file can error out if the directory does not exist yet. Some places already had `mkdir -p` calls, but not all. Make all occurences of this consistently use `@$(MKDIR_P)`. (Extension of PR #12575 to catch more places.) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* | | | | | Merge pull request #12708 from donaldsharp/no_notificationMark Stapp2023-01-311-3/+6
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | zebra: Send nht resolved entry up to concerned protocols in all cases
| * | | | | zebra: Send nht resolved entry up to concerned protocols in all casesDonald Sharp2023-01-311-3/+6
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There existed the idea, from Volta, that a nexthop group would not have the same nexthops installed -vs- what FRR actually sent down. The dplane would notify you. With the addition of 06525c4f99d4dcafdf448565f7e11bd70993697d the code was put behind a bit of a wall controlled the usage of it. The flag ROUTE_ENTRY_USE_FIB_NHG flag was being used to control which set was being sent up to concerned parties in nexthop tracking. Put this flag behind the wall and do not necessarily set it when we receive a data plane notification about a route being installed or not. Fixes: #12706 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | | | Merge pull request #12695 from opensourcerouting/format-warningsDonald Sharp2023-01-3136-116/+207
|\ \ \ \ \ | | | | | | | | | | | | build: `-Wformat-nonliteral -Wformat-security`
| * | | | | build: enable format string warningsDavid Lamparter2023-01-271-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I thought these were included in `-Wall -Wextra`, but apparently not. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
| * | | | | bfdd: fix size_t format stringDavid Lamparter2023-01-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
| * | | | | bgpd: fix silly format string SNAFUDavid Lamparter2023-01-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Someone thought vty_out accepts a list of strings. It does not. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
| * | | | | bgpd: fix format string mess in AS-path printingDavid Lamparter2023-01-273-14/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was done *very* weirdly. Make it slightly less so. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
| * | | | | lib: literal constant format string for termtableDavid Lamparter2023-01-271-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While this wasn't a problematic use of a format string, make it a literal constant so the compiler is happy. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
| * | | | | *: fix non-const northbound XPath format stringsDavid Lamparter2023-01-279-41/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Passing a pre-formatted buffer in these places needs a `"%s"` in front so it doesn't get formatted twice. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
| * | | | | *: no-warn pragmas for non-const format stringsDavid Lamparter2023-01-279-0/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We do use non-constant/literal format strings in a few places for more or less valid reasons; put `ignored "-Wformat-nonliteral"` around those so we can have the warning enabled for everywhere else. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
| * | | | | *: apply proper format string attributesDavid Lamparter2023-01-2713-53/+87
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | So that we get warnings about broken format strings. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* | | | | Merge pull request #12710 from ↵Donald Sharp2023-01-315-22/+102
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | opensourcerouting/fix/reset_fqdn_capability_on_before_handling_open bgpd: Vanish FQDN capability hostname/domainname before handling new BGP OPEN
| * | | | | bgpd: Vanish FQDN capability hostname/domainname before handling new BGP OPENDonatas Abraitis2023-01-301-10/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this, if the peer disables sending FQDN capability, the old hostname still (STALE) exists and is misleading in the outputs of `show bgp ...`. Especially when using with `bgp default show-hostname`, etc. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
| * | | | | bgpd: Free peer's hostname (aka FQDN capability stuff)Donatas Abraitis2023-01-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
| * | | | | tests: Check if we vanish hostname/domainname if disabled from another sideDonatas Abraitis2023-01-303-12/+93
| | |_|/ / | |/| | | | | | | | | | | | | Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* | | | | Merge pull request #12711 from opensourcerouting/topotest-pid-fixDonald Sharp2023-01-311-5/+6
|\ \ \ \ \ | |_|_|/ / |/| | | | tests: Topotests fix for deleting wrong pidfile
| * | | | tests: Topotests fix for deleting wrong pidfileMartin Winter2023-01-301-5/+6
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | Fixes killRouterDaemons() function which occasionally deleted the wrong pidfile. Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
* | | | Merge pull request #12709 from donaldsharp/update_withdraw_always_workDonatas Abraitis2023-01-316-138/+89
|\ \ \ \ | |/ / / |/| | | bgpd: bgp_update and bgp_withdraw never return failures
| * | | bgpd: bgp_update and bgp_withdraw never return failuresDonald Sharp2023-01-306-138/+89
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | These two functions always return 0. As such any and all tests against this make no sense. Remove the return 0 to a void and follow the chain, logically, to remove all the dead code. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | Merge pull request #12700 from taspelund/martian_tip_improvementDonatas Abraitis2023-01-303-17/+40
|\ \ \ | | | | | | | | BGP Martian Tunnel-IP Improvements
| * | | bgpd: move tunnel-ip comparison into handlerTrey Aspelund2023-01-271-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moves the old/new IP comparison into handle_tunnel_ip_change instead of expecting the caller to do the check on their own. Also changes handle_tunnel_ip_change to return void since it only ever returned 0 in all cases. Signed-off-by: Trey Aspelund <taspelund@nvidia.com>
| * | | bgpd: only unimport routes if tunnel-ip changesTrey Aspelund2023-01-273-11/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When processing a new local VNI, we were always walking the global EVPN table to look for routes that needed to be removed due to a martian nexthop change (specifically a tunnel-ip change). Since the martian TIP table is global (all VNIs) + the walk is also in the global table (all VNIs), we can trust that any new TIP from any VNI would result in routes getting removed from the global table and unimported from all live (L2)VNIs. i.e. The only time this update is actionable is if we are adding/removing an IP from the martian TIP table, and we do not need to walk the table for normal refcount adjustments. Signed-off-by: Trey Aspelund <taspelund@nvidia.com>
* | | | Merge pull request #12703 from donaldsharp/basic_babelDonatas Abraitis2023-01-3012-10/+549
|\ \ \ \ | |/ / / |/| | | Basic babel
| * | | tests: Super simple babel testDonald Sharp2023-01-2810-0/+539
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Just get babel started and ensure that the v4 routes are actually installed. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | babeld: During intf startup, ignore address already in useDonald Sharp2023-01-281-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When listening on a multicast group. No need to actually fail the operation when it's already being used. Let's not treat the Address already in use error message as one that is stopping everything from working. Especially since multiple interface events cause this to happen. Without this, if config is read in before full connection to zebra, babel will never establish neighbors. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | babeld: The function is already a pointerDonald Sharp2023-01-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Don't send the address of in. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | | Merge pull request #12690 from ↵Donald Sharp2023-01-271-0/+17
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | opensourcerouting/feature/deny_merging_prs_with_freeze_label github: Prevent merging (fail CI) if 'freeze' label exists for PR
| * | | | github: Prevent merging (fail CI) if 'freeze' label exists for PRDonatas Abraitis2023-01-251-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mostly useful duging the freeze period to warn the maintainers from merging unwanted PRs. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* | | | | Merge pull request #12691 from mjstapp/fix_dplane_prov_lockDonald Sharp2023-01-271-8/+0
|\ \ \ \ \ | | | | | | | | | | | | zebra: fix SA warning, don't lock plugin list
| * | | | | zebra: fix SA warning, don't lock plugin listMark Stapp2023-01-251-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Locking around the list of providers/plugins is not helpful - these only change at init time. Clear some SA warnings by removing the locking. Signed-off-by: Mark Stapp <mjs@labn.net>
* | | | | | Merge pull request #12696 from donaldsharp/shadowedDonatas Abraitis2023-01-275-17/+12
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Shadowed
| * | | | | lib: Remove global variable exposure `struct host host`Donald Sharp2023-01-262-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was only used in one place and we have accessor functions now. So let's use them. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | watchfrr: dmn variable shadows previous declarationDonald Sharp2023-01-261-7/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no need to declar the same temp variable 2 times. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | zebra: i declaration shadows other i declaredDonald Sharp2023-01-261-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clear up some confustion Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | | lib: Forward declaration of a struct does not need to have data typeDonald Sharp2023-01-261-1/+1
|/ / / / / | | | | | | | | | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | | | Merge pull request #12694 from donaldsharp/zebra_rib_dead_codeRafael Zalamena2023-01-263-50/+1
|\ \ \ \ \ | |/ / / / |/| | | | remove dead code
| * | | | lib: Remove dead codeDonald Sharp2023-01-252-25/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | wheel_stop and wheel_start have never been used. Let's just remove them. After close to 7 years, if needed someone else can add back in. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | | zebra: Remove impossible to use functionDonald Sharp2023-01-251-25/+1
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | The rib_update_handle_vrf function is no longer being used. Cleanup it's usage from zebra. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | | Merge pull request #12685 from louis-6wind/fix-vpnv4-noretainDonatas Abraitis2023-01-253-22/+39
|\ \ \ \ | | | | | | | | | | topotests: fix bgp_vpnv4_noretain
| * | | | topotests: fix bgp_vpnv4_noretainLouis Scalbert2023-01-243-22/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the following issues: - two tests are done in one function. Dispatch the tests in two functions to help the test debug. - the first test passes even if a third prefix is not filtered. Match the exact to avoid false positive. - the expected values contains variable like version. Do no check variable values. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
* | | | | Merge pull request #12660 from Pdoijode/ip-nht-json-changesDonatas Abraitis2023-01-255-400/+299
|\ \ \ \ \ | | | | | | | | | | | | zebra: fix JSON fields for "show ip/ipv6 nht"
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-11 14:10:23 +0100