summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #13660 from anlancs/bgpd-cleanup-12mobash-rasool2023-06-021-3/+3
|\ | | | | bgpd: Fix typo in debug message
| * bgpd: Fix typo in debug messageanlan_cs2023-06-011-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cosmetic change for the debug messages, mainly on the parentheses. Before: ``` [ZJYCS-KQYD6] VRF vrf-debug(140): Rcvd NH update 50.50.50.0/24(0)0) - metric 300/300 #nhops 2/1 flags Valid Reg Static Static Exact [VZJVD-D7GXM] parse nexthop update(50.50.50.0/24(0)(VRF vrf-debug)): bnc info not found for nexthop cache [NSWTE-81HEK] parse nexthop update(50.50.201.0/31(0)(VRF vrf-debug)): bnc info not found for import check ``` After: ``` [ZJYCS-KQYD6] VRF vrf-debug(140): Rcvd NH update 50.50.50.0/24(0)(0) - metric 300/300 #nhops 2/1 flags Valid Reg Static Static Exact [VZJVD-D7GXM] parse nexthop update 50.50.50.0/24(0)(VRF vrf-debug): bnc info not found for nexthop cache [NSWTE-81HEK] parse nexthop update 50.50.201.0/31(0)(VRF vrf-debug): bnc info not found for import check ``` Signed-off-by: anlan_cs <vic.lan@pica8.com>
* | Merge pull request #13637 from yyuanam/fix_vtysh_coreDonatas Abraitis2023-06-011-2/+6
|\ \ | | | | | | lib: fix vtysh core when handling questionmark
| * | lib: fix vtysh core when handling questionmarkYuan Yuan2023-05-311-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When issue vtysh command with ?, the initial buf size for the element is 16. Then it would loop through each element in the cmd output vector. If the required size for printing out the next element is larger than the current buf size, realloc the buf memory by doubling the current buf size regardless of the actual size that's needed. This would cause vtysh core when the doubled size is not enough for the next element. Signed-off-by: Yuan Yuan <yyuanam@amazon.com>
* | | Merge pull request #13653 from dpward/ospf6d-redundant-lsaDonatas Abraitis2023-06-011-1/+0
|\ \ \ | | | | | | | | ospf6d: Prevent redundant LSA generation before interface goes down
| * | | ospf6d: Prevent redundant LSA generation before interface goes downDavid Ward2023-05-311-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 76249532faad ("ospf6d: Handle Premature Aging of LSAs") added a duplicate call to OSPF6_INTRA_PREFIX_LSA_EXECUTE_TRANSIT(), when the interface state changes to "Down". Fixes: #1738 Signed-off-by: David Ward <david.ward@ll.mit.edu>
* | | | Merge pull request #13652 from ↵Donald Sharp2023-06-011-9/+9
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | opensourcerouting/fix/drop_old_releases_from_the_table doc: Update reference table for current and upcoming release dates
| * | | | doc: Update reference table for current and upcoming release datesDonatas Abraitis2023-05-311-9/+9
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Keep only 3 release dates, current and two upcoming. On the next release, just update one, instead of multiple (zero point looking too much in the future). Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* | | | Merge pull request #13450 from patrasar/mld_coreDonatas Abraitis2023-06-011-3/+5
|\ \ \ \ | |/ / / |/| | | pim6d: Fix crash in ipv6 pim command
| * | | pim6d: Fix crash in ipv6 pim commandSarita Patra2023-05-301-3/+5
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: Execute the below commands, pim6d core happens. interface ens193 ip address 69.0.0.2/24 ipv6 address 8000::1/120 ipv6 mld ipv6 pim We see crash only if the interface is not configured, and we are executing PIM/MLD commands. RootCause: Interface ens193 is not configured. So, it will have ifindex = 0 and mroute_vif_index = -1. Currently, we don't enable MLD on an interface if mroute_vif_index < 0. So, pim_ifp->MLD = NULL. In the API pim_if_membership_refresh(), we are accessing pim_ifp->MLD NULL pointer which leads to crash. Fix: Added NULL check before accessing pim_ifp->MLD pointer in the API pim_if_membership_refresh(). Issue: #13385 Signed-off-by: Sarita Patra <saritap@vmware.com>
* | | Merge pull request #13632 from LabNConsulting/chopps/mgmt-avoid-raceDonald Sharp2023-05-312-42/+9
|\ \ \ | | | | | | | | mgmtd: fix possible race btw read config and backend connection
| * | | mgmtd: fix possible race btw read config and backend connectionChristian Hopps2023-05-302-42/+9
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
* | | | Merge pull request #13639 from opensourcerouting/ospf-timestamp-truncationDonald Sharp2023-05-314-4/+5
|\ \ \ \ | | | | | | | | | | ospfd, ospf6d: fix time_t truncation
| * | | | ospfd, ospf6d: fix time_t truncationRenato Westphal2023-05-314-4/+5
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | Change timestamp parameter from int to time_t to avoid truncation. Found by Coverity Scan (CID 1563226 and 1563222) Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
* | | | Merge pull request #13634 from yyuanam/fix_bgp_coreDonatas Abraitis2023-05-311-0/+4
|\ \ \ \ | | | | | | | | | | bgpd: fix bgpd core when unintern attr
| * | | | bgpd: fix bgpd core when unintern attrYuan Yuan2023-05-311-0/+4
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the remote peer is neither EBGP nor confed, aspath is the shadow copy of attr->aspath in bgp_packet_attribute(). Striping AS4_PATH should not be done on the aspath directly, since that would lead to bgpd core dump when unintern the attr. Signed-off-by: Yuan Yuan <yyuanam@amazon.com>
* | | | Merge pull request #13635 from donaldsharp/give_ping_a_chanceJafar Al-Gharaibeh2023-05-311-1/+2
|\ \ \ \ | |/ / / |/| | | tests: Actually loop if ping fails
| * | | tests: Actually loop if ping failsDonald Sharp2023-05-301-1/+2
|/ / / | | | | | | | | | | | | | | | | | | The usage of run_and_expect doesn't work if the function being called as the run part asserts. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | Merge pull request #13631 from donaldsharp/fix_some_ping_issuesDonatas Abraitis2023-05-304-4/+15
|\ \ \ | | | | | | | | various issues
| * | | lib, zebra: Ensure that the ifp->node existsDonald Sharp2023-05-282-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On removal, ensure that the ifp->node is set to a null pointer so that FRR does not use data after freed. In addition ensure that the ifp->node exists before attempting to free it. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | pimd: When doing json output do not output non-json stringsDonald Sharp2023-05-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When entering some show commands that use json in pimd when the interface cannot be found do not output non-json format in that case. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
| * | | tests: Allow ping to run multiple times before failingDonald Sharp2023-05-281-2/+9
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | the bgp_default_originate test brings up the topology and then immediately pings. Which sometimes fails. This is of course possible since the first ping might actually fail due to arp going on. So let's give it a second chance or two. Especially since the test, at this point, is just installing a default route. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | | Merge pull request #13601 from opensourcerouting/build-yang-embed-20230525Donald Sharp2023-05-302-2/+7
|\ \ \ | | | | | | | | build: fix missing YANG model embedding
| * | | ripd: embed BFD YANG modelsDavid Lamparter2023-05-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | The frr-ripd model has a dependency on frr-bfdd, so include it in build. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
| * | | mgmtd: embed necessary YANG modelsDavid Lamparter2023-05-251-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Listing `.c` files in `$(…_OBJECTS):` does not have the desired effect. (Also CLEANFILES is not needed, yang/subdir.am already has yang/*.c in CLEANFILES anyway.) Fixes: #13600 Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* | | | Merge pull request #13588 from sri-mohan1/srib-ldpd1mobash-rasool2023-05-301-54/+49
|\ \ \ \ | |_|_|/ |/| | | ldpd: changes for code maintainability
| * | | ldpd: changes for code maintainabilitysri-mohan12023-05-231-54/+49
| | | | | | | | | | | | | | | | | | | | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* | | | Merge pull request #13414 from LabNConsulting/chopps/no-mgmtd-nowrite-on-offDonald Sharp2023-05-3049-2530/+2921
|\ \ \ \ | |_|_|/ |/| | | rework messaging, resource handling in mgmtd with bug fix and code hardening
| * | | zebra: use ifindex vs ifp to avoid use-after-free on shutdownChristian Hopps2023-05-302-7/+17
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | zebra: avoid unneeded vxlan work on shutdownChristian Hopps2023-05-301-1/+3
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | tests: add unified config testsChristian Hopps2023-05-308-197/+311
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - simple unified test - unified test with late backend startup test Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | mgmtd: address review commentsChristian Hopps2023-05-304-14/+8
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | mgmtd: fix clang uninit warningChristian Hopps2023-05-301-1/+3
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | tests: add some more mgmtd testsChristian Hopps2023-05-308-0/+418
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | mgmtd: cleanup BE xpath subscription and matching codeChristian Hopps2023-05-305-241/+261
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | lib: mgmtd: fix memleaksChristian Hopps2023-05-303-2/+7
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | lib: mgmtd: add manual vty server start option and use itChristian Hopps2023-05-306-21/+44
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | lib: mgmtd: fixes for startup config file processingChristian Hopps2023-05-305-51/+136
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | mgmtd: Add note to SETCFG_REQ and debug loggingChristian Hopps2023-05-301-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | - convert impossible situation into assert Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | mgmtd: simplify early config build removing unused codeChristian Hopps2023-05-304-181/+74
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | mgmtd: fix reading of config file[s]Christian Hopps2023-05-308-86/+211
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | lib: enable short circuit for FE client/adapter connectionChristian Hopps2023-05-282-3/+17
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | staticd: remove connect notify function, not neededChristian Hopps2023-05-281-3/+8
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | mgmtd: lib: cleanup error and debug messagesChristian Hopps2023-05-285-272/+316
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - always use IDs not a mix of IDs and pointers. - always use PRIu64 not a mix of hex and decimal for IDs Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | mgmtd: lib: move INIT to after client registersChristian Hopps2023-05-282-0/+11
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | mgmtd: send reply to SUBSCR_REQ with success or notChristian Hopps2023-05-281-9/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | since we don't actually handle xpath subscriptions, reply with fail if they are requested. Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | lib: add short-circuit operation between same processChristian Hopps2023-05-286-36/+162
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - Use a socketpair for connection, and direct (no event loop) message sending and handling. Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | lib: mgmtd: add a identifying tag to the debug messageChristian Hopps2023-05-284-10/+12
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | lib: dont be tricky with session_id just make it a session_idChristian Hopps2023-05-285-292/+239
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Previously was substituting a pointer to local allocated session for the session_id returned from the FE adapter. This complexity isn't needed. - Get rid of "%llu" format and the casts that came with it, instead use PRIu64 and the actual (uint64_t) type. Signed-off-by: Christian Hopps <chopps@labn.net>
| * | | mgmtd: fix cleanup of cleanup in FE adapter codeChristian Hopps2023-05-281-48/+41
| | | | | | | | | | | | | | | | Signed-off-by: Christian Hopps <chopps@labn.net>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-30 03:43:21 +0100