summaryrefslogtreecommitdiffstats
path: root/eigrpd (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #3543 from donaldsharp/eigrp_router_id_is_the_beeRenato Westphal2019-01-025-30/+24
|\ | | | | Eigrp router id cleanup
| * eigrpd: Allow eigrp to set/unset the router-id as a value.Donald Sharp2018-12-311-8/+10
| | | | | | | | | | | | | | | | | | This code addition allows eigrp to set/unset the router-id value. At this point I am not 100% sure that we do all the necessary rework when a router-id changes. But on startup if read in before a network statement we should be ok. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
| * eigrpd: eigrp usage of uint32_t to struct in_addr for router_id dataDonald Sharp2018-12-315-19/+14
| | | | | | | | | | | | | | | | In eigrp we were using a uint32_t to hold the `struct in_addr` data for the router id values. This caused us to do unnecessary conversions pre and post for in/out. Let's just use the standard `struct in_addr` Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
| * eigrpd: Write eigrp config even if no network statements yetDonald Sharp2018-12-311-3/+0
| | | | | | | | | | | | | | Let's write the eigrp config even if we have no network statements as that the other functions return safely if nothing to do here. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | lib, rip, ripng, babel, eigrp: add ctx pointer to distribute apiPhilippe Guibert2018-12-286-7/+25
|/ | | | | | | | | | | | | | | | | | | | | | a distribute_ctx context pointer is returned after initialisation to the calling daemon. this context pointer will be further used to do discussion with distribute service. Today, there is no specific problem with old api, since the pointer is the same in all the memory process. but the pointer will be different if we have multiple instances. Right now, this is not the case, but if that happens, that work will be used for that. distribute-list initialisation is split in two. the vty initialisation is done at global level, while the context initialisation is done for each routing daemon instance. babel daemon is being equipped with a routing returning the main babel instance. also, a delete routine is available when the daemon routing instance is suppressed. a list of contexts is used inside distribute_list. This will permit distribute_list utility to handle in the same daemon to handle more than one context. This will be very useful in the vrf context. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
* *: remove all MIBs for DFSG complianceDavid Lamparter2018-12-142-1323/+0
| | | | | | | | | cf. https://wiki.debian.org/NonFreeIETFDocuments These MIBs were in our git purely for documentation purposes, they are not installed and not needed for building SNMP support. Signed-off-by: David Lamparter <equinox@diac24.net>
* *: Replace zclient_new with zclient_new_notifyDonald Sharp2018-11-121-1/+1
| | | | | | | It's been a year since we added the new optional parameters to instantiation. Let's switch over to the new name. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* yang, lib: add 'frr-interface.yang' and associated stub callbacksRenato Westphal2018-10-271-0/+1
| | | | | | | | | | | | | Introduce frr-interface.yang, which defines a model for managing FRR interfaces. Update the 'frr_yang_module_info' array of all daemons that will implement this module. Add automatically generated stub callbacks in if.c. These callbacks will be implemented in the following commit. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
* *: add empty array of YANG modulesRenato Westphal2018-10-271-1/+5
| | | | | | | | | | FRR_DAEMON_INFO should now contain an array of 'frr_yang_module_info' structures describing the YANG modules implemented by the daemon. This array will be used by frr_init() function to load all YANG modules and initialize the northbound callbacks during the daemon initialization. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
* Merge pull request #3199 from donaldsharp/eigrp_keyDavid Lamparter2018-10-262-48/+29
|\ | | | | Eigrp cli stuff
| * eigrpd: Fix bandwidth command to actually read input properlyDonald Sharp2018-10-251-6/+3
| | | | | | | | | | | | | | The bandwidth command was not properly reading cli input and would do weird stuff with the input. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
| * eigrpd: Convert keychain authentication to DEFPYDonald Sharp2018-10-252-42/+26
| | | | | | | | | | | | | | | | | | | | | | The keychain authentication code under eigrp was using the wrong argv numbers for keychain lookup. Convert to DEFPY. I do not actually know if this allows eigrp authentication to work. But this connects up a bit more of the pieces if it does. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | *: spelchekDavid Lamparter2018-10-253-5/+5
|/ | | | Signed-off-by: David Lamparter <equinox@diac24.net>
* Merge pull request #3120 from opensourcerouting/remove-list-deleteLou Berger2018-10-026-20/+20
|\ | | | | lib: remove deprecated list_delete()/list_free()
| * *: list_delete_and_null() -> list_delete()David Lamparter2018-10-026-20/+20
| | | | | | | | Signed-off-by: David Lamparter <equinox@diac24.net>
* | eigrpd: dead code (Coverity 1460436)F. Aragon2018-10-021-4/+1
|/ | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* Merge pull request #3072 from donaldsharp/fix_eigrp_crash_on_int_shutRuss White2018-09-243-16/+11
|\ | | | | eigrpd: Fix eigrp crash on shut of a interface
| * eigrpd: Fix eigrp crash on shut of a interfaceDonald Sharp2018-09-223-16/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | The eigrp interface structure was storing a pointer to the connected interface structure and on shutdown of an interface this would cause zebra to call eigrp back with a shutdown of that interface, as part of that operation the connected interface structure is being deleted, but eigrp was keeping a pointer to the connected structure. At the same time we were keeping the address of the connected structure and this is all we need, so keep a copy of that data and use that instead. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* | eigrpd: Fix memory leaks and remove dead/unused functionsDonald Sharp2018-09-243-37/+9
|/ | | | | | | | During shutdown we were not properly cleaning up some memory as reported by valgrind. Additionally during cleanup operations I noticed that there were some dead/unused functions remove/reduce. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* *: style for EC replacementsQuentin Young2018-09-135-15/+15
| | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* *: LIB_[ERR|WARN] -> EC_LIBQuentin Young2018-09-133-4/+4
| | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* eigrpd: EIGRP_[ERR|WARN] -> EC_EIGRPQuentin Young2018-09-136-8/+8
| | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* Merge pull request #2977 from opensourcerouting/doc-fixDonald Sharp2018-09-091-1/+1
|\ | | | | build: fix not building docs w/o sphinx
| * build: fix not building docs w/o sphinxDavid Lamparter2018-09-091-1/+1
| | | | | | | | | | | | Can't build manpages without sphinx-build, oops... Signed-off-by: David Lamparter <equinox@diac24.net>
* | *: fix config.h/zebra.h include orderDavid Lamparter2018-09-081-1/+1
|/ | | | | | | | config.h (or, transitively, zebra.h) must be the first include file listed for autoconf things like _GNU_SOURCE and _POSIX_C_SOURCE to work correctly. Signed-off-by: David Lamparter <equinox@diac24.net>
* *: cleanup .gitignore filesDavid Lamparter2018-09-081-16/+0
| | | | Signed-off-by: David Lamparter <equinox@diac24.net>
* build: move vtysh & manpage listings to subdir.amDavid Lamparter2018-09-081-0/+6
| | | | | | | Since we're now building through one large Makefile, we can easily put things with their daemons and crossreference nicely. Signed-off-by: David Lamparter <equinox@diac24.net>
* eigrp: opnional metric in 'no redistribute'dturlupov2018-09-061-1/+1
| | | | Signed-off-by: Dmitrii Turlupov <dturlupov@factor-rs.ru>
* *: add a vrf update hook to be informed of the vrf namePhilippe Guibert2018-08-281-1/+1
| | | | | | | | The Vrf aliases can be known with a specific hook. That hook will then, from zebra propagate the information to the relevant zapi clients. The registration hook function is the same for all daemons. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
* *: use frr_elevate_privs() (2/2: manual)David Lamparter2018-08-141-50/+27
| | | | Signed-off-by: David Lamparter <equinox@diac24.net>
* *: use frr_elevate_privs() (1/2: coccinelle)David Lamparter2018-08-141-15/+11
| | | | Signed-off-by: David Lamparter <equinox@diac24.net>
* *: rename ferr_zlog -> flog_err_sysQuentin Young2018-08-142-4/+5
| | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* *: rename ferr_ref -> log_refQuentin Young2018-08-142-3/+3
| | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* *: rename zlog_fer -> flog_errQuentin Young2018-08-147-16/+16
| | | | Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* *: stop double initialization of ferrQuentin Young2018-08-141-2/+0
| | | | | | | | * Stop double init of ferr * Fixup bugs in zebra ferr * Add missing init in ospfd Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* *: fix source file headers & includes for errcodesQuentin Young2018-08-142-21/+24
| | | | | | | | | | * Use the correct license header * Stop headers from including themselves * Use uniform relative include conventions * Ensure that sources include what they use * Turn off clang-format around struct array blocks Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* eigrpd: Add EIGRP_ERR_XXX for zlog_err to zlog_ferrDonald Sharp2018-08-1410-15/+109
| | | | Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* eigrpd: Convert to use LIB_ERR_XXX for zlog_errDonald Sharp2018-08-144-23/+27
| | | | | | Convert, where appropriate, to using LIB_ERR_XXX for zlog_ferr Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* Merge pull request #2603 from pacovn/PVS-Studio_format_warningsQuentin Young2018-07-021-1/+2
|\ | | | | eigrpd nhrpd ospfd pimd: fomat fixes (PVS-Studio)
| * eigrpd nhrpd ospfd pimd: fomat fixes (PVS-Studio)F. Aragon2018-07-021-1/+2
| | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | eigrpd: sizeof() usage + dead code (PVS-Studio)F. Aragon2018-07-021-3/+3
|/ | | | | | | | | | Two issues: 1) Removed an unnecesary null check of 'ei' 2) Fixed the usage of sizeof(), as it was used the size of a pointer instead of the size of the structure Signed-off-by: F. Aragon <paco@voltanet.io>
* eigrpd ospfd: null chk (Coverity 1458168 1455335)paco2018-06-251-0/+2
| | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* eigrpd: null check (Coverity 1455334 and 4 alike)paco2018-06-213-5/+20
| | | | | | | | Coverity issues fixed with this commit: 1455334 1455335 1455336 1455337 1455339 Signed-off-by: F. Aragon <paco@voltanet.io>
* Merge pull request #2491 from pacovn/cppcheck_no_effectRuss White2018-06-191-2/+0
|\ | | | | eigrpd, isisd, lib, ospfd: no effect (cppcheck)
| * eigrpd, isisd, lib, ospfd: no effect (cppcheck)paco2018-06-191-2/+0
| | | | | | | | | | | | Assignment of function parameter has no effect outside the function. Signed-off-by: F. Aragon <paco@voltanet.io>
* | eigrpd, lib, tests, vtysh: security (cppcheck)paco2018-06-191-1/+0
|/ | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* Merge pull request #2484 from pacovn/cppcheck_unused_varsDonald Sharp2018-06-182-7/+4
|\ | | | | eigrpd, lib: unused vars (cppcheck)
| * eigrpd, lib, vtysh: unused vars (cppcheck)paco2018-06-182-7/+4
| | | | | | | | Signed-off-by: F. Aragon <paco@voltanet.io>
* | babeld, eigrpd, ospfd: unsigned negative checkpaco2018-06-181-1/+1
|/ | | | | | After Cppcheck 1.72 feedback Signed-off-by: F. Aragon <paco@voltanet.io>
* eigrpd: null return value check (Coverity 1455338)paco2018-06-121-0/+1
| | | | Signed-off-by: F. Aragon <paco@voltanet.io>
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-22 05:15:53 +0100