summaryrefslogtreecommitdiffstats
path: root/ldpd/labelmapping.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2017-04-01lib: fix usage of getgrouplist() in *BSDMike Tancsa1-1/+1
On BSD systems, the getgrouplist() function returns 0 if successful and -1 on error. Linux in the other hand returns *ngroups (the number of groups of which user is a member) on success and -1 on error. Given this difference, the most portable way to use getgrouplist() is use its return value only for checking if it succeeded or not. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-03-30Rename: freerangerouting --> frroutingLou Berger27-52/+52
Signed-off-by: Lou Berger <lberger@labn.net>
2017-03-30Rename: FreeRangeRouting FRRoutingLou Berger25-62/+62
Signed-off-by: Lou Berger <lberger@labn.net>
2017-03-28*: track version & "defaults" in configsDavid Lamparter13-51/+170
[CF]: Move default name to autoconf and update tests Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-03-28tests: format TestRefMismatch more readableChristian Franke1-1/+13
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-03-25COMMUNITY.md: update CodingStyle & branchingDavid Lamparter2-15/+799
Also add a note that this is documentation, not law. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-03-18snapcraft: Change setup/ to snap/ directory based on new snap formatMartin Winter2-1/+1
DEPRECATED: Assets in 'setup/gui' should now be placed in 'snap/gui'. See http://snapcraft.io/docs/deprecation-notices/dn3 for more information. Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-03-18snapcraft: Add missing snapcraft files from dist (make dist) archiveMartin Winter1-10/+4
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-03-15zebra: zebra_fpm_dt.c does not always need protobufDonald Sharp1-0/+2
When compiling zebra_fpm_dt.c only pull in protobuf headers if we've turned it on. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-03-15zebra: Fix protobuf build on stable/2.0Donald Sharp1-2/+2
When compiling w/ --enable-protobuf on stable/2.0 we were attempting to dereference the zvrf->vrf_id which got moved to zvrf->vrf->vrf_id. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-03-11snapcraft: Replace temporary logo with official FRR logoMartin Winter1-0/+0
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-03-10zebra: Fix specific prefix handlingDonald Sharp1-4/+1
Suppose we are handling the process_workq and either a new static route is installed or a Routing Protocol installs a new route. We will call evaluate_rnh with a specific prefix. We might have a situation where we clear the NHC flag prematurely. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-03-09lib: handle case specifc types, protect against double free (issue #144)Lou Berger1-0/+2
Signed-off-by: Lou Berger <lberger@labn.net> [DL: dropped changes except the two NULL assignments] Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-03-09Revert "lib: Fix tab completions memleak, memory stats corruption"David Lamparter1-10/+4
This reverts commit 039dc61292de5f3ed5f46316b1940ab6bb184c3f. The patch actually made the situation worse since the return value from cmd_complete_command_real() was now inconsistently allocated from different memory stat pools. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-03-09Lowercase frr.confMartín Beauchamp12-30/+30
2017-03-09zebra: Notify all nexthops that we've changedDonald Sharp1-7/+36
Zebra when it was scanning the tree would unset NEXTHOPS_CHANGED after the first notification. If the route we are notifying because of covers multiple interesting nexthops then we would be unable to know that we need to notify for that one as well because of the flag removal. Ticket: CM-15157 Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-03-07vtysh: fix completionDavid Lamparter1-1/+1
The return value from cmd_complete_command is a VECTOR_INDEX, not TMP. Use the appropriate vector_only_index_free(). Fixes #223. Reported-by: https://github.com/k0ste Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-03-07bgpd: Clean up bfd memory *before* deleting the peerDonald Sharp1-2/+2
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-03-02bgpd: Fix memory leaks on shutdownDonald Sharp1-2/+2
The original code on shutdown assumed a 'forced' mode if there was no process_main_queue. This construct was violated by commit 2e02b9b2d1ed29975001d6917f9f726854ec5559 due to not fully understanding the shutdown process. If we are shutting down, don't store work to do later, just gracefully don't do it. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
2017-02-27*: remove QUAGGA_NO_DEPRECATED_INTERFACESQuentin Young2-19/+0
This define is used only to guard macros in lib/linklist.h which themselves are not used anywhere in the codebase and have been marked deprecated since anno domini 2005 Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
2017-02-23bgpd: Fix issue #218Lou Berger1-1/+1
Wrong offset was used when using global V6 address in place of v6 LL. (Introduced in earlier fix of broken RD advertisement.) Tested by @dslice in master. Signed-off-by: Lou Berger <lberger@labn.net>
2017-02-23bgpd: fix bgp_info_addpath_{rx,tx}_str if addpath info is not presentChristian Franke2-0/+4
The buffer needs to be set to length 0 if nothing is written into it, otherwise bgpd will log uninitialized memory, disclosing information and possibly leading to a crash. Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-02-23release: FRR 2.0-rc2frr-2.0-rc2Martin Winter1-1/+1
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-02-21Add missing DESC_ENTRY to lib/log.cßingen1-0/+1
2017-02-16doc: Fix pytest installation instructions on Ubuntu 12.04Martin Winter1-1/+5
Ubuntu 12.04 doesn't have a pytest package - needs to be installed with pip Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-02-16doc: Fixed a few typos on Building Doc's, Changed Tab's to spaces and ↵Martin Winter14-991/+1050
limited line length to < 80 chars where possible Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-02-16doc: Add initial set of docs on building FRR on various DistributionsMartin Winter15-4/+1574
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-02-15ldpd: fix segfault when configuring multiple pseudowiresRenato Westphal1-8/+8
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-02-15ldpd: use red-black trees to store 'adj' elementsRenato Westphal8-55/+78
Using red-black trees instead of linked lists brings the following benefits: 1 - Elements are naturally ordered (no need to reorder anything before outputting data to the user); 2 - Faster lookups/deletes: O(log n) time complexity against O(n). The insert operation with red-black trees is more expensive though, but that's not a big issue since lookups are much more frequent. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-02-15ldpd: use red-black trees to store 'l2vpn_pw' elementsRenato Westphal6-78/+86
Using red-black trees instead of linked lists brings the following benefits: 1 - Elements are naturally ordered (no need to reorder anything before outputting data to the user); 2 - Faster lookups/deletes: O(log n) time complexity against O(n). The insert operation with red-black trees is more expensive though, but that's not a big issue since lookups are much more frequent. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-02-15ldpd: use red-black trees to store 'l2vpn_if' elementsRenato Westphal6-37/+44
Using red-black trees instead of linked lists brings the following benefits: 1 - Elements are naturally ordered (no need to reorder anything before outputting data to the user); 2 - Faster lookups/deletes: O(log n) time complexity against O(n). The insert operation with red-black trees is more expensive though, but that's not a big issue since lookups are much more frequent. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-02-15ldpd: use red-black trees to store 'l2vpn' elementsRenato Westphal6-39/+47
Using red-black trees instead of linked lists brings the following benefits: 1 - Elements are naturally ordered (no need to reorder anything before outputting data to the user); 2 - Faster lookups/deletes: O(log n) time complexity against O(n). The insert operation with red-black trees is more expensive though, but that's not a big issue since lookups are much more frequent. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-02-15ldpd: use red-black trees to store 'nbr_params' elementsRenato Westphal6-37/+45
Using red-black trees instead of linked lists brings the following benefits: 1 - Elements are naturally ordered (no need to reorder anything before outputting data to the user); 2 - Faster lookups/deletes: O(log n) time complexity against O(n). The insert operation with red-black trees is more expensive though, but that's not a big issue since lookups are much more frequent. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-02-15ldpd: use red-black trees to store 'tnbr' elementsRenato Westphal9-54/+66
Using red-black trees instead of linked lists brings the following benefits: 1 - Elements are naturally ordered (no need to reorder anything before outputting data to the user); 2 - Faster lookups/deletes: O(log n) time complexity against O(n). The insert operation with red-black trees is more expensive though, but that's not a big issue since lookups are much more frequent. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-02-15ldpd: use red-black trees to store 'iface' elementsRenato Westphal7-49/+57
Using red-black trees instead of linked lists brings the following benefits: 1 - Elements are naturally ordered (no need to reorder anything before outputting data to the user); 2 - Faster lookups/deletes: O(log n) time complexity against O(n). The insert operation with red-black trees is more expensive though, but that's not a big issue since lookups are much more frequent. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-02-15ldpd: use red-black trees to store 'lde_map' elementsRenato Westphal4-17/+31
Using red-black trees instead of linked lists brings the following benefits: 1 - Elements are naturally ordered (no need to reorder anything before outputting data to the user); 2 - Faster lookups/deletes: O(log n) time complexity against O(n). The insert operation with red-black trees is more expensive though, but that's not a big issue since lookups are much more frequent. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
2017-02-13*: Add missing files to gitignoreChristian Franke2-2/+2
2017-02-13isisd: address coverity findingsChristian Franke6-21/+18
2017-02-13tests: fix out-of-tree buildDavid Lamparter2-3/+9
Fix pytest with $(top_srcdir) != "." Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-02-13tests: add pytest testrunnersChristian Franke16-0/+511
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-02-13tests: reorganize tests hierarchicallyChristian Franke34-97/+124
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-02-13tests: remove dejagnuChristian Franke18-425/+0
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
2017-02-10ospfd: CID 1399387 (#1 of 2): Destination buffer too small (STRING_OVERFLOW)Martin Winter1-1/+1
Coverity: string_overflow: You might overrun the 100-character destination string vty_path by writing 4096 characters from vty_sock_path. Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-02-10lib: CID 1399296: Assign instead of compare (PW.ASSIGN_WHERE_COMPARE_MEANT)Martin Winter1-1/+1
Needs to be a comparison, not assignment Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-02-10zebra: Fix CID 1399335 (#1 of 1): Wrong sizeof argument (SIZEOF_MISMATCH)Martin Winter1-1/+1
Needs to be size of correct structure (prefix instead of prefix_ipv4) Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-02-10vtysh: Fix Coverity Warning CID 1399479 (#1 of 1): Destination buffer too ↵Martin Winter1-1/+1
small (BUFFER_SIZE) Coverity: buffer_size: You might overrun the 108 byte destination string addr.sun_path by writing the maximum 4095 bytes from path. Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-02-10ospfd: Fix Coverity Warning CID 1399480 (#1 of 1): Buffer not null ↵Martin Winter1-1/+1
terminated (BUFFER_SIZE_WARNING) Coverity: buffer_size_warning: Calling strncpy with a maximum size argument of 100 bytes on destination array pid_file of size 100 bytes might leave the destination string unterminated. Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
2017-02-09ospfclient: #include sourcesDavid Lamparter2-1/+5
Pulling in source files from another directory breaks automake's distclean target, and there seems to be no good fix for this... (particularly since we need -fPIC build for a DSO here, while ospfd compiles for an executable...) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-02-09lib: use fsync() for config writes, plug fd leakDavid Lamparter2-27/+45
sync() has a HUGE impact on systems that perform actual I/O, i.e. real servers... Also, we were leaking a fd on each config write ever since c5e69a0 "lib/vty: add separate output fd support to VTYs" (by myself :( ...) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
2017-02-07*: Found some instances of Quagga.confDonald Sharp4-7/+7
Cleanup Quagga.conf -> Frr.conf Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>