summaryrefslogtreecommitdiffstats
path: root/ospfclient (follow)
Commit message (Collapse)AuthorAgeFilesLines
* lib/xref: put setup calls in librariesDavid Lamparter2021-02-011-0/+3
| | | | | | | | Our "true" libraries (i.e. not modules) don't invoke neither FRR_DAEMON_INFO nor FRR_MODULE_SETUP, hence XREF_SETUP isn't invoked either. Invoke it directly to get things working. Signed-off-by: David Lamparter <equinox@diac24.net>
* ospfclient: replace inet_ntoaMark Stapp2020-10-221-14/+15
| | | | | | Replace all use of inet_ntoa; use pI4 (and printfrr). Signed-off-by: Mark Stapp <mjs@voltanet.io>
* ospfd: fix SA warnings in ospfd, ospfclientMark Stapp2020-10-141-6/+12
| | | | | | Fix some SA warnings in ospf GR and ospfclient code. Signed-off-by: Mark Stapp <mjs@voltanet.io>
* ospfclient: Provide some protection against blindly trusting inputDonald Sharp2020-10-091-2/+17
| | | | | | | | | Coverity rightly points out that blindly trusting the lsalen from received data may not be the smartest thing to do. Add a bit of code to prevent us from blindly malloc'ing too much memory. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* *: Replace s_addr 0 => INADDR_ANYDonatas Abraitis2020-02-061-1/+1
| | | | Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
* ospfclient: don't install man pageDavid Lamparter2020-01-151-1/+1
| | | | | | | ... we're not installing ospfclient (it's a demo/example program), so installing the man page is quite useless. Signed-off-by: David Lamparter <equinox@diac24.net>
* doc: rename man pages to frr-*David Lamparter2020-01-151-1/+1
| | | | | | | | The vrrpd one conflicts with the standalone vrrpd package; also we're installing daemons to /usr/lib/frr on some systems so they're not on PATH. Signed-off-by: David Lamparter <equinox@diac24.net>
* build: fix a whole bunch of *FLAGSDavid Lamparter2019-01-301-1/+1
| | | | | | | | | - some target_CFLAGS that needed to include AM_CFLAGS didn't do so - libyang/sysrepo/sqlite3/confd CFLAGS + LIBS weren't used at all - consistently use $(FOO_CFLAGS) instead of @FOO_CFLAGS@ - 2 dependencies were missing for clippy Signed-off-by: David Lamparter <equinox@diac24.net>
* build: make rfptest and ospfclient "noinst"David Lamparter2018-10-281-1/+1
| | | | | | | | | | Both of these are testing/demo-style tools that don't make sense as part of a normal installation. So don't install them. NB: this is only the executables, libospfclient and the RFP code are not affected. Signed-off-by: David Lamparter <equinox@diac24.net>
* build: add --enable-static-bin optionDavid Lamparter2018-10-011-1/+13
| | | | | | | | | This option can be used to get statically linked binaries. Note: libfrr.la is removed from modules' library dependency list. This is intentional and explained in a comment in lib/subdir.am. Signed-off-by: David Lamparter <equinox@diac24.net>
* build: fix not building docs w/o sphinxDavid Lamparter2018-09-091-1/+1
| | | | | | Can't build manpages without sphinx-build, oops... Signed-off-by: David Lamparter <equinox@diac24.net>
* *: cleanup .gitignore filesDavid Lamparter2018-09-081-15/+0
| | | | Signed-off-by: David Lamparter <equinox@diac24.net>
* build: move vtysh & manpage listings to subdir.amDavid Lamparter2018-09-081-0/+1
| | | | | | | Since we're now building through one large Makefile, we can easily put things with their daemons and crossreference nicely. Signed-off-by: David Lamparter <equinox@diac24.net>
* ospfd: Remove unused functionDonald Sharp2018-08-211-0/+1
| | | | | | | | | | | | | The ospf_external_route_lookup function was not being used so let's just remove it. Unfortunately the removal was not quite so simple as that ospf_asbr.h was being used to generate a reference for the `struct ospf_route` data structure, so we need to fix up the compile by fixing up header inclusions so that ospf_route.h is actually included Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* *: ALLOC calls cannot failDonald Sharp2018-08-111-8/+2
| | | | | | | | There is no need to check for failure of a ALLOC call as that any failure to do so will result in a assert happening. So we can safely remove all of this code. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* *: use C99 standard fixed-width integer typesQuentin Young2018-03-273-46/+46
| | | | | | | | | | | | | | | | | | | | | | The following types are nonstandard: - u_char - u_short - u_int - u_long - u_int8_t - u_int16_t - u_int32_t Replace them with the C99 standard types: - uint8_t - unsigned short - unsigned int - unsigned long - uint8_t - uint16_t - uint32_t Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* Merge pull request #911 from opensourcerouting/non-recursive-2Donald Sharp2017-08-094-29/+41
|\ | | | | more non-recursive build, fix cross-compile, & doc build mangling
| * build: non-recursive ospf*David Lamparter2017-08-044-29/+41
| | | | | | | | Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* | lib: privs: make uid/gid accessible before setuidDavid Lamparter2017-08-021-0/+1
|/ | | | | | | | This splits off privs_preinit(), which does the lookups for user and group IDs. This is so the init code can create state directories while still running as root. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* *: reindentreindent-master-afterwhitespace / reindent2017-07-173-862/+755
| | | | | | indent.py `git ls-files | pcregrep '\.[ch]$' | pcregrep -v '^(ldpd|babeld|nhrpd)/'` Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* lib: more `show thread cpu`Quentin Young2017-06-301-1/+1
| | | | | | | Add support for naming pthreads. Also, note that we don't have any records yet if that's the case. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* *: simplify log message lookupQuentin Young2017-06-211-2/+2
| | | | | | | | | | | | | | | | log.c provides functionality for associating a constant (typically a protocol constant) with a string and finding the string given the constant. However this is highly delicate code that is extremely prone to stack overflows and off-by-one's due to requiring the developer to always remember to update the array size constant and to do so correctly which, as shown by example, is never a good idea.b The original goal of this code was to try to implement lookups in O(1) time without a linear search through the message array. Since this code is used 99% of the time for debugs, it's worth the 5-6 additional cmp's worst case if it means we avoid explitable bugs due to oversights... Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* ospfclient: Free up leaked resources in error pathDonald Sharp2017-06-131-0/+5
| | | | Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* *: Clean up call into inet_atonDonald Sharp2017-06-131-3/+19
| | | | | | | In the few places where we were not checking the return code for inet_aton, do so. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* *: make consistent & update GPLv2 file headersDavid Lamparter2017-05-153-14/+11
| | | | | | | | | | | The FSF's address changed, and we had a mixture of comment styles for the GPL file header. (The style with * at the beginning won out with 580 to 141 in existing files.) Note: I've intentionally left intact other "variations" of the copyright header, e.g. whether it says "Zebra", "Quagga", "FRR", or nothing. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* *: remove THREAD_ON macros, add nullity checkQuentin Young2017-05-091-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The way thread.c is written, a caller who wishes to be able to cancel a thread or avoid scheduling it twice must keep a reference to the thread. Typically this is done with a long lived pointer whose value is checked for null in order to know if the thread is currently scheduled. The check-and-schedule idiom is so common that several wrapper macros in thread.h existed solely to provide it. This patch removes those macros and adds a new parameter to all thread_add_* functions which is a pointer to the struct thread * to store the result of a scheduling call. If the value passed is non-null, the thread will only be scheduled if the value is null. This helps with consistency. A Coccinelle spatch has been used to transform code of the form: if (t == NULL) t = thread_add_* (...) to the form thread_add_* (..., &t) The THREAD_ON macros have also been transformed to the underlying thread.c calls. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
* ospfclient: fix gcc -O0 buildDavid Lamparter2017-02-142-0/+6
| | | | | | | | the "static const" inside DECLARE_MTYPE still causes issues on gcc -O0 (re. gcc bug 69981). Work around by disabling MTYPE declarations for ospfclient. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* ospfclient: #include sourcesDavid Lamparter2017-02-092-1/+5
| | | | | | | | | Pulling in source files from another directory breaks automake's distclean target, and there seems to be no good fix for this... (particularly since we need -fPIC build for a DSO here, while ospfd compiles for an executable...) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* ospfd: isolate ospfapiclient lib from ospf libDavid Lamparter2017-02-072-4/+6
| | | | | | | | The OSPF API-client library doesn't really use anything from libospf except some small dumping tools. Isolate these into a separate file and detangle the ospfapiclient library. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* *: Convert libospf -> libfrrospfDonald Sharp2017-02-031-6/+6
| | | | | | | | Convert the libospfapiclient -> libfrrospfapiclient and libospf -> libfrrospf to prevent namespace collision with Quagga. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* *: Convert libzebra -> libfrrDonald Sharp2017-02-032-3/+3
| | | | | | | The library libzebra that is installed with FRR will conflict with Quagga. So let's rename it to libfrr. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* lib: migrate to new memory-type handlingDavid Lamparter2016-09-192-2/+2
| | | | | | | | | Move over to the new allocation counting added in the previous commit. (This commit is mostly mechanical.) Signed-off-by: David Lamparter <equinox@opensourcerouting.org> Acked-by: Vincent JARDIN <vincent.jardin@6wind.com>
* quagga: remove refix directory from git statusDonald Sharp2016-09-091-1/+1
| | | | | | | | | During one of our build processes we are getting a refix directory in some places. Remove these from files that git considers Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com> (cherry picked from commit 844cbf5d6cdfc6961e99e1c9ed35b826f3aa7562)
* *: get rid of "MTYPE 0"David Lamparter2016-07-281-1/+1
| | | | | | | | | | | A few places are using 0 in place of the MTYPE_* argument. The following rewrite of the alloc tracking won't deal with that, so let's use MTYPE_TMP instead. Acked-by: Vincent JARDIN <vincent.jardin@6wind.com> Acked-by: Donald Sharp <sharpd@cumulusnetworks.com> [DL: v2: fix XFREE(0, foo) calls too] Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* build: get rid of INCLUDES, use AM_CPPFLAGSDavid Lamparter2016-06-031-1/+1
| | | | | | | | | | | | | INCLUDES in configure.ac was not used at all, and INCLUDES in Makefile.am is supposed to be AM_CPPFLAGS these days. Reduces warnings spewed during bootstrap/autoreconf. Signed-off-by: David Lamparter <equinox@opensourcerouting.org> Acked-by: Greg Troxel <gdt@ir.bbn.com> Acked-by: Feng Lu <lu.feng@6wind.com> Acked-by: Paul Jakma <paul@jakma.org> (cherry picked from commit 237aac56960575f6ad2451ba2796d94bd5ae4b33)
* build: make libraries self-reliantDavid Lamparter2016-05-261-0/+1
| | | | | | | | | libospf and libospfclient both need libzebra, so they should link against it. The days of libtool propagating upwards such dependencies are nearing their end... Signed-off-by: David Lamparter <equinox@opensourcerouting.org> (cherry picked from commit d8d5c60ecfab4dd609a07b4baa00d735f59002b9)
* Add missing GPL headers, and copyright claims that certainly apply.Paul Jakma2016-05-261-0/+18
| | | | | | | | | | | | | | | * Fix (a subset of)? files with non-trivial code that are missing GPL headers. * A few copyright claims added which I am certain apply, but which I had missed out on the original commits. NB: Copyright claims are not exclusive and the addition of any copyright claim should not be read as implying a lack of any further claims, or denying the validity of any other claims. All those with claims of copyright over any portion of Quagga are welcome to submit them, ideally as patches to update copyright strings in files. (cherry picked from commit 010ebbbca6396f272cc2d50d147dd922dda68213)
* build: Remove the old PIC/PIE patch, let libtool sort it outPaul Jakma2016-05-261-3/+2
| | | | | | | * Remove the old change from '08 to add in PIE arguments at automake level. Versions of libtool since then know how to deal with -fpie and do the right thing according to whether its building shared or executable objects. So just pass '-fpie' as CFLAG and let libtool do its thing.
* Quagga: Fixup some compile warningsDonald Sharp2015-11-231-1/+1
| | | | | | Fixup compile warnings for when you turn on --enable-gcc-ultra-verbose=yes Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
* Add --enable-werror to configureDonald Sharp2015-07-261-0/+1
|
* *: nuke ^L (page feed)David Lamparter2014-06-041-5/+5
| | | | | | | | | | | | | | Quagga sources have inherited a slew of Page Feed (^L, \xC) characters from ancient history. Among other things, these break patchwork's XML-RPC API because \xC is not a valid character in XML documents. Nuke them from high orbit. Patches can be adapted simply by: sed -e 's%^L%%' -i filename.patch (you can type page feeds in some environments with Ctrl-V Ctrl-L) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* build: correct libtool parameter used within MakefilesBrad Smith2012-09-251-1/+1
| | | | | | | | This corrects the parameters passed to libtool when linking the shared libraries. The paramter name is -version-info not -version. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* build: allow configure and build in a separate directoryVincent Bernat2012-06-251-1/+1
| | | | | | | | | | | Some .h files in lib/ are autogenerated. The search path should include the build directory and the source directory. They usually match but sometimes, they may be different. For example: $ mkdir build $ cd build $ ../configure $ make
* build: delete .cvsignore filesDenis Ovsienko2011-12-131-13/+0
|
* [cleanup] Add log.h includesTomasz Pala2009-06-241-0/+1
|
* [cleanup] Convert XMALLOC/memset to XCALLOCStephen Hemminger2009-06-121-2/+1
| | | | Simple conversion of XMALLOC/memset to XCALLOC
* [administrivia] Git should ignore backup files and .loT filesPaul Jakma2008-08-221-0/+3
|
* [trivia] Remove ChangeLog files, as this data is now maintained in SCMPaul Jakma2008-08-221-71/+0
|
* [warnings] Fix various SOS warningsPaul Jakma2008-08-221-1/+1
| | | | | | | | | | | | | 2008-08-15 Paul Jakma <paul.jakma@sun.com> * */*: Fix various problems flagged by Sun Studio compiler. - '<qualifier> <storage>' obsolescent in declarations - empty statements (';' after ALIAS definitions) - implicit declarations (e.g printstack in lib/log.c) - "\%" in printf string instead of "%%" - loops that return on the first iteration (legitimately, but compiler can't really know), e.g. bgp_routemap.c - internal declarations which mask prototypes.
* [build] Test for GNU-style PIE support in toolchain and enablePaul P Komkoff Jr2008-08-221-0/+2
| | | | | | | | | | | 2008-08-13 Paul P Komkoff Jr <i@stingr.net> * configure.ac: add a configure flag and autoconf macro, which will determine if your toolchain supports PIE. * */Makefile.am: add corresponding CFLAGS and LDFLAGS into appropriate places. Signed-off-by: Paul Jakma <paul@quagga.net>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-12 06:48:57 +0100