summaryrefslogtreecommitdiffstats
path: root/python (follow)
Commit message (Collapse)AuthorAgeFilesLines
* [ospfd]: add support for RFC 5709 HMAC-SHA AuthMahdi Varasteh2023-09-161-1/+1
| | | | | | | | | | | | This patch includes: * Implementation of RFC 5709 support in OSPF. Using openssl library and FRR key-chain, one can use SHA1, SHA256, SHA384, SHA512 and keyed-MD5( backward compatibility with RFC 2328) HMAC algs. * Updating documentation of OSPF * add topotests for new HMAC algorithms Signed-off-by: Mahdi Varasteh <varasteh@amnesh.ir>
* mgmtd: fully implement debug flags for mgmtd and clientsChristian Hopps2023-05-011-0/+2
| | | | Signed-off-by: Christian Hopps <chopps@labn.net>
* lib: convert xref_threadsched to xref_eventschedDonald Sharp2023-03-241-2/+2
| | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* *: Rename thread.[ch] to event.[ch]Donald Sharp2023-03-241-1/+1
| | | | | | | | | | | This is a first in a series of commits, whose goal is to rename the thread system in FRR to an event system. There is a continual problem where people are confusing `struct thread` with a true pthread. In reality, our entire thread.c is an event system. In this commit rename the thread.[ch] files to event.[ch]. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* mgmtd: nb library for client front-end codeChristian Hopps2023-03-221-0/+10
| | | | Signed-off-by: Christian Hopps <chopps@labn.net>
* Merge pull request #12248 from pguibert6WIND/bgpasdotRuss White2023-02-211-0/+7
|\ | | | | lib, bgp: add initial support for asdot format
| * lib, bgp: add initial support for asdot formatPhilippe Guibert2023-02-101-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | AS number can be defined as an unsigned long number, or two uint16 values separated by a period (.). The possible valus are: - usual 32 bit values : [1;2^32 -1] - <1.65535>.<0.65535> for dot notation - <0.65535>.<0.65535> for dot+ notation. The 0.0 value is forbidden when configuring BGP instances or peer configurations. A new ASN type is added for parsing in the vty. The following commands use that new identifier: - router bgp .. - bgp confederation .. - neighbor <> remote-as <> - neighbor <> local-as <> - clear ip bgp <> - route-map / set as-path <> An asn library is available in lib/ and provides some services: - convert an as string into an as number. - parse an as path list string and extract a number. - convert an as number into a string. Also, the bgp tests forge an as_zero_path, and to do that, an API to relax the possibility to have a 0 as value is specifically called from the tests. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
* | *: auto-convert to SPDX License IDsDavid Lamparter2023-02-0910-140/+10
|/ | | | | | Done with a combination of regex'ing and banging my head against a wall. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* python: hide inet_ntoa from frrbotDavid Lamparter2022-10-281-2/+3
| | | | | | These are not the inet_ntoa you are looking for ;) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* python: fix a bunch of pylint warnings in clippyDavid Lamparter2022-10-281-0/+14
| | | | Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* python: apply black formattingDavid Lamparter2022-10-289-299/+491
| | | | | | | The python/ directory hasn't been shoved into black yet (unlike topotests, where most FRR python code is.) Run black over it. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* build: exclude a few more things from frr.xrefDavid Lamparter2022-10-261-1/+6
| | | | | | ... this might need some better approach long-term. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* python: fix for old (< 3.6) Python versionsDavid Lamparter2022-10-261-21/+24
| | | | | | Sigh. No type annotations, no f-strings. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* build, vtysh: extract vtysh commands from .xrefDavid Lamparter2022-10-263-72/+396
| | | | | | | | | | | | | | | | | | | Rather than running selected source files through the preprocessor and a bunch of perl regex'ing to get the list of all DEFUNs, use the data collected in frr.xref. This not only eliminates issues we've been having with preprocessor failures due to nonexistent header files, but is also much faster. Where extract.pl would take 5s, this now finishes in 0.2s. And since this is a non-parallelizable build step towards the end of the build (dependent on a lot of other things being done already), the speedup is actually noticeable. Also files containing CLI no longer need to be listed in `vtysh_scan` since the .xref data covers everything. `#ifndef VTYSH_EXTRACT_PL` checks are equally obsolete. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* python: use ujson if availableDavid Lamparter2022-10-061-3/+12
| | | | | | It's noticeably faster. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* build: don't include vtysh.xref in frr.xrefDavid Lamparter2022-10-061-0/+3
| | | | | | | | vtysh.xref only contains a rather-useless duplicate of every single CLI command incorporated into vtysh... and including it prevents frr.xref from becoming the source for vtysh_cmd.c. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* lib: add CMD_ATTR_NOSHDavid Lamparter2022-10-061-0/+2
| | | | | | To propagate into .xref so extract.pl can be handled there. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* lib: make cmd_element->attr a bitmask & clarifyDavid Lamparter2022-10-062-7/+29
| | | | | | | | | It already "looks" like a bitmask, but we currently can't flag a command both YANG and HIDDEN at the same time. It really should be a bitmask. Also clarify DEPRECATED behaviour (or the absence thereof.) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* python: Remove redundant import of subprocessDonald Sharp2022-06-161-1/+0
| | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* build: reformat makefile.pyDavid Lamparter2022-05-261-8/+18
| | | | Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* build: add a bunch of comments to makefile.pyDavid Lamparter2022-05-261-0/+16
| | | | | | ... to (maybe?) make understandable what it's doing. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* build: fix LLVM bitcode per-target CFLAGSDavid Lamparter2022-05-261-1/+10
| | | | | | | When automake decides to customize CFLAGS, use those for building LLVM bitcode files too. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* python: improve clippy/clidef macro processingDavid Lamparter2022-02-281-15/+47
| | | | | | | Process macros from the current file, and warn if something is redefined (to a different value). Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* python: pass conditionals through clippy for DEFPYDavid Lamparter2022-01-131-2/+22
| | | | | | | | Track what conditionals apply when a DEFPY is encountered, and stack them around the autogenerated clippy wrapper. Otherwise conditional DEFPYs result in undefined function warnings. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* isisd: fix redistribute CLIIgor Ryzhov2021-10-051-0/+2
| | | | | | | | | | | | | | | | | | | | | Currently, it is possible to configure IPv6 protocols for IPv4 redistribution and vice versa in CLI. The YANG model doesn't allow this so the user receives the following error: ``` nfware(config-router)# redistribute ipv4 ospf6 level-1 % Failed to edit configuration. YANG error(s): Invalid enumeration value "ospf6". Invalid enumeration value "ospf6". Invalid enumeration value "ospf6". YANG path: Schema location /frr-isisd:isis/instance/redistribute/ipv4/protocol. ``` Let's make CLI more user-friendly and allow only supported protocols in redistribution commands. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
* build: add `-Werror` to xrelfo log format warningsDavid Lamparter2021-06-241-1/+5
| | | | | | | | | Adding a `\n' should now produce a warning. Controlled by `-Werror` so if you're doing a dev build and it's warning about some `prefix2str` that should be converted to `%pFX`, you can turn off `-Werror` to fix it later like with all other warnings. Signed-off-by: David Lamparter <equinox@diac24.net>
* *: make sure `config.h` or `zebra.h` is firstDavid Lamparter2021-04-231-16/+76
| | | | | | | | | | | | `config.h` has all the defines from autoconf, which may include things that switch behavior of other included headers (e.g. _GNU_SOURCE enabling prototypes for additional functions.) So, the first include in any `.c` file must be either `config.h` (with the appropriate guard) or `zebra.h` (which includes `config.h` first thing.) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* python: add demo checker tool using frr.xrefDavid Lamparter2021-04-151-0/+72
| | | | | | | More of a demo on what to do with the frr.xref file, but also slightly useful in finding vtysh SNAFUs :) Signed-off-by: David Lamparter <equinox@diac24.net>
* python: fix 32-bit pointers in xrelfo container_ofDavid Lamparter2021-04-081-1/+4
| | | | | | | This was mistakenly using the host platform's pointer size rather than the ELF file's. Only noticeable when cross compiling... Signed-off-by: David Lamparter <equinox@diac24.net>
* python/xrelfo: cross-platform xrefstructs.jsonDavid Lamparter2021-02-232-67/+19
| | | | | | | | | | Just get names, types and order from pahole; ditch offset & size since they're different on 32/64 bit. None of the structs has padding currently; if we really need that it can be implemented in the future. (Padding will raise an exception, so it won't break silently.) Signed-off-by: David Lamparter <equinox@diac24.net>
* lib/xref: record log message format argsDavid Lamparter2021-02-232-16/+49
| | | | | | | | | | | Apparently you can do `#__VA_ARGS__` and it actually does something sensible, so here we go recording the format parameters for log messages into the xref. This allows some more checking in xrelfo.py, e.g. hints to use `%pFX` and co. Signed-off-by: David Lamparter <equinox@diac24.net>
* build: extract xrefsDavid Lamparter2021-02-231-0/+12
| | | | Signed-off-by: David Lamparter <equinox@diac24.net>
* python/xrelfo: the ELF xref extractorDavid Lamparter2021-02-238-0/+1508
| | | | | | This creates JSON dumps of all the xref structs littered around FRR. Signed-off-by: David Lamparter <equinox@diac24.net>
* *: reformat python fileswhitespace2020-10-076-278/+419
| | | | | | We are now using black. Signed-off-by: Quentin Young <qlyoung@nvidia.com>
* python: Make FRR build compatible with python 2.7 and 3.xMartin Winter2020-08-191-1/+1
| | | | Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
* build: fix Makefile rule redefinitionDavid Lamparter2020-07-171-1/+8
| | | | Signed-off-by: David Lamparter <equinox@diac24.net>
* python: add graphviz callgraphsDavid Lamparter2020-05-051-0/+476
| | | | | | Uses the JSON data extracted from LLVM bitcode by tools/frr-llvm-cg. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* build: add LLVM bitcode targetsDavid Lamparter2020-05-051-0/+25
| | | | | | | Just an easy way to produce LLVM .bc (bitcode) files. Not used during normal builds. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* build: rework Makefile var extraction... againDavid Lamparter2020-05-052-16/+53
| | | | | | *sigh* I can't seem to catch a break on this. Add a regex variant. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* python: add check-first-header toolDavid Lamparter2020-04-271-0/+30
| | | | | | | The first #include statement in all FRR .c files should be either zebra.h or config.h. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* build: make clippy Makefile rules nicerDavid Lamparter2020-04-271-0/+100
| | | | | | | These are easy to get subtly wrong, and doing so can cause nondeterministic failures when racing in parallel builds. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* python: move MakeVars class into separate moduleDavid Lamparter2020-04-271-0/+50
| | | | | | ... so I can reuse it. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* bgpd/bmp: BMP implementationDavid Lamparter2019-08-301-0/+1
| | | | | | | | This implements BMP. There's no fine-grained history here, the non-BMP preparations are already split out from here so all that remains is BMP proper. Signed-off-by: David Lamparter <equinox@diac24.net>
* clippy: find headers relative to source treeDavid Lamparter2019-07-031-1/+3
| | | | | | | The current directory is in the build tree while running clippy; find ourselves so we can access headers from the source tree. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* lib/clippy: expand some macrosDavid Lamparter2019-06-121-9/+41
| | | | | | At least the "easy" cases of macros work. Signed-off-by: David Lamparter <equinox@diac24.net>
* lib/clippy: assert() for non-optional argsDavid Lamparter2019-06-121-4/+34
| | | | | | | | | This is mostly to help static analysis; since we know from the command string which args are optional and which aren't, we can add assert() statements on them. Fixes: #3270 Signed-off-by: David Lamparter <equinox@diac24.net>
* lib/clippy: error out on unsupported bitsDavid Lamparter2019-06-121-1/+19
| | | | | | | | | clippy can't process #ifdef or similar bits inside of an argument list (e.g. within the braces of a DEFUN or DEFPY statement.) Improve error reporting to catch these cases instead of generating broken C code. Fixes: #3840 Signed-off-by: David Lamparter <equinox@diac24.net>
* python: make DEFPY provide the text token of fixed parametersRenato Westphal2019-01-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the CLI code, each cmd_token has both a "text" field, containing the full token text (e.g. "unicast"), and an "arg" field, containing the original text entered by the user (which might be an abbreviation, like "uni" instead of "unicast"). To avoid the need to handle abbreviations, the recommended pattern for DEFUN commands is to use the "text" value of fixed parameters and the "arg" value of everything else. Using DEFPY, however, the CLI parameters are automagically turned into C variables which are initialized under the hood (so that they're conveniently ready for use). The problem is that this initialization was always using the "arg" value of the parameters, which was leading to problems like these: debian# show ipv6 route isi Unknown route type debian# debian# conf t debian(config)# router isis 1 debian(config-router)# redistribute ipv4 st level-1 % Configuration failed. Invalid value "st" in "protocol" element. YANG path: /frr-isisd:isis/instance[area-tag='1']/redistribute/ipv4[protocol='st']/protocol To fix these problems (and probably others too), make DEFPY commands auto-detect the type of the input parameters and use either the "arg" or "text" value from the cmd_tokens accordingly. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
* Revert "isisd lib ospfd pbrd python: fix empty init"David Lamparter2018-12-011-5/+5
| | | | | | | | | This reverts commit 48944eb65e1d1ced03d46121d923d9d613a480d5. We're using GNU C, not ISO C - and this commit triggers new (real) warnings about {0} instead of bogus ones about {}. Signed-off-by: David Lamparter <equinox@diac24.net>
* isisd lib ospfd pbrd python: fix empty initF. Aragon2018-11-211-5/+5
| | | | | | | ISO C forbids empty initializer braces. Empty initializers have been replaced with {0} Signed-off-by: F. Aragon <paco@voltanet.io>