From 00a7f422c346f8cb0a79c5b9a4dd119ca122292c Mon Sep 17 00:00:00 2001 From: Stephen Worley Date: Fri, 2 Aug 2019 11:12:33 -0400 Subject: lib: Remove double log mutex unlock Coverity report caught this log mutex being unlocked twice. Removing the extra one before the goto statement. Signed-off-by: Stephen Worley --- lib/log.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/log.c b/lib/log.c index 48ee0f6ad..8e4d2bc60 100644 --- a/lib/log.c +++ b/lib/log.c @@ -387,10 +387,8 @@ void vzlog(int priority, const char *format, va_list args) /* If it doesn't match on a filter, do nothing with the debug log */ if ((priority == LOG_DEBUG) && zlog_filter_count - && vzlog_filter(zl, &tsctl, proto_str, priority, msg)) { - pthread_mutex_unlock(&loglock); + && vzlog_filter(zl, &tsctl, proto_str, priority, msg)) goto out; - } /* call external hook */ hook_call(zebra_ext_log, priority, format, args); -- cgit v1.2.3