From fe86c6b3b15c9972c8894b9f07b1a2e640271b3e Mon Sep 17 00:00:00 2001 From: Quentin Young Date: Wed, 18 Mar 2020 12:02:19 -0400 Subject: lib: remove null check before free nh_labels Signed-off-by: Quentin Young --- lib/nexthop.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/nexthop.c b/lib/nexthop.c index e23f8b079..c3be0a71e 100644 --- a/lib/nexthop.c +++ b/lib/nexthop.c @@ -415,10 +415,8 @@ void nexthop_add_labels(struct nexthop *nexthop, enum lsp_types_t type, /* Free label information of nexthop, if present. */ void nexthop_del_labels(struct nexthop *nexthop) { - if (nexthop->nh_label) { - XFREE(MTYPE_NH_LABEL, nexthop->nh_label); - nexthop->nh_label_type = ZEBRA_LSP_NONE; - } + XFREE(MTYPE_NH_LABEL, nexthop->nh_label); + nexthop->nh_label_type = ZEBRA_LSP_NONE; } const char *nexthop2str(const struct nexthop *nexthop, char *str, int size) -- cgit v1.2.3