From 6cd8093d3207e86d318953c3ebd4b9120078a742 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Wed, 11 Mar 2020 09:03:17 -0400 Subject: ldpd: During code inspection we are mixing data sizes As I understand it ldpd was originally developed as a standalone daemon for *BSD land. Then ported to FRR. FRR uses ifindex_t as the base type for the ifindex. Mixing `unsigned short` and `int` and `unsigned int` is going to lead to fun somewhere along the way. Especially when we get to run on a system with ifindex churn( I'm looking at you docker ). Attempt to convert all of ldpd to think of the ifindex as a `ifindex_t`. Signed-off-by: Donald Sharp --- ldpd/hello.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ldpd/hello.c') diff --git a/ldpd/hello.c b/ldpd/hello.c index d17e80008..a8d6e58cd 100644 --- a/ldpd/hello.c +++ b/ldpd/hello.c @@ -169,7 +169,7 @@ recv_hello(struct in_addr lsr_id, struct ldp_msg *msg, int af, int tlvs_rcvd; int ds_tlv; union ldpd_addr trans_addr; - uint32_t scope_id = 0; + ifindex_t scope_id = 0; uint32_t conf_seqnum; uint16_t trans_pref; int r; -- cgit v1.2.3