summaryrefslogtreecommitdiffstats
path: root/common
diff options
context:
space:
mode:
authorWerner Koch <wk@gnupg.org>2017-01-23 16:32:44 +0100
committerWerner Koch <wk@gnupg.org>2017-01-23 16:33:01 +0100
commitaf5979a42b9468ffe0f3ac6de5a77d982c5cf8a0 (patch)
tree783da2ea7d5f6d964dbb0ed9b233c86e27c70f84 /common
parentdirmngr: On SIGHUP mark all keyservers alive. (diff)
downloadgnupg2-af5979a42b9468ffe0f3ac6de5a77d982c5cf8a0.tar.xz
gnupg2-af5979a42b9468ffe0f3ac6de5a77d982c5cf8a0.zip
Fix format string errors and some missing error case initialization.
* common/logging.c (do_logv): Remove extra parentheses in comparison. * dirmngr/dns-stuff.c (resolve_addr_libdns): Init RES so that dns_res_close is given a defined value in the error case. * dirmngr/http.c (cookie_read, cookie_write) [HTTP_USE_NTBTLS]: Fix format string char. * dirmngr/ks-engine-hkp.c (ks_hkp_help): Remove duplicate "const". * dirmngr/ks-engine-http.c (ks_http_help): Ditto. * dirmngr/ks-engine-kdns.c (ks_kdns_help): Ditto. * dirmngr/ks-engine-ldap.c (ks_ldap_help): Ditto. * scd/app-p15.c (send_keypairinfo, do_getattr): Fix format string char. * tools/gpgconf-comp.c (gpg_agent_runtime_change): Init PID for the error case. (scdaemon_runtime_change): Ditto. (dirmngr_runtime_change): Ditto. * tools/gpgconf.c (query_swdb): Init VALUE_SIZE_UL. Signed-off-by: Werner Koch <wk@gnupg.org>
Diffstat (limited to 'common')
-rw-r--r--common/logging.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/common/logging.c b/common/logging.c
index 0db1860c1..8c70742cc 100644
--- a/common/logging.c
+++ b/common/logging.c
@@ -798,7 +798,7 @@ do_logv (int level, int ignore_arg_ptr, const char *extrastring,
es_fputs_unlocked ("\\\\", logstream);
else if (c == '\r')
es_fputs_unlocked ("\\r", logstream);
- else if ((c == '\n'))
+ else if (c == '\n')
{
es_fputs_unlocked ("\\n\n", logstream);
if (*extrastring)