diff options
| author | Werner Koch <wk@gnupg.org> | 2020-12-14 15:18:01 +0100 |
|---|---|---|
| committer | Werner Koch <wk@gnupg.org> | 2020-12-14 19:29:49 +0100 |
| commit | cc056eb534c1b8f7d1a90af3b9ecb9d6b2f322fa (patch) | |
| tree | fe95dcd9ff5ae786516005551415ad0086245f56 /dirmngr/server.c | |
| parent | dirmngr: Fix adding keys to an LDAP server. (diff) | |
| download | gnupg2-cc056eb534c1b8f7d1a90af3b9ecb9d6b2f322fa.tar.xz gnupg2-cc056eb534c1b8f7d1a90af3b9ecb9d6b2f322fa.zip | |
dirmngr: Do not store the useless pgpSignerID in the LDAP.
* dirmngr/ks-engine-ldap.c (extract_attributes): Do not store the
pgpSignerID.
* g10/call-dirmngr.c (ks_put_inq_cb): Do not emit sig records.
--
The pgpSignerID has no use in the LDAP and thus don't store it.
David's idea back in 2004 was
/* This bit is really for the benefit of people who
store their keys in LDAP servers. It makes it easy
to do queries for things like "all keys signed by
Isabella". */
See-commit: 3ddd4410aef928827e1c8d4fb02c1ccd3f8eaea5
I consider this dangerous because such a query is not able to validate
the signature, does not get revocation signatures, and also has no
information about the validity of the signatures. Further many keys
are spammed tehse days with faked signatures and it does not make
sense to blow up the LDAP with such garbage.
Signed-off-by: Werner Koch <wk@gnupg.org>
Diffstat (limited to 'dirmngr/server.c')
| -rw-r--r-- | dirmngr/server.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/dirmngr/server.c b/dirmngr/server.c index 66ef1c8c9..f6c2c45f1 100644 --- a/dirmngr/server.c +++ b/dirmngr/server.c @@ -2526,7 +2526,7 @@ static const char hlp_ks_put[] = " INQUIRE KEYBLOCK_INFO\n" "\n" "The client shall respond with a colon delimited info lines (the output\n" - "of 'for x in keys sigs; do gpg --list-$x --with-colons KEYID; done').\n"; + "of 'gpg --list-keys --with-colons KEYID').\n"; static gpg_error_t cmd_ks_put (assuan_context_t ctx, char *line) { @@ -2559,8 +2559,7 @@ cmd_ks_put (assuan_context_t ctx, char *line) goto leave; } - /* Ask for the key meta data. Not actually needed for HKP servers - but we do it anyway to test the client implementation. */ + /* Ask for the key meta data. */ err = assuan_inquire (ctx, "KEYBLOCK_INFO", &info, &infolen, MAX_KEYBLOCK_LENGTH); if (err) |