diff options
| author | Werner Koch <wk@gnupg.org> | 2019-05-12 20:41:32 +0200 |
|---|---|---|
| committer | Werner Koch <wk@gnupg.org> | 2020-04-01 09:58:11 +0200 |
| commit | c7ff8c59b9252f8f27cabee3fea503f06c7d46ff (patch) | |
| tree | 912d884694489285caa14ab7bd5d73f12611b4ae /sm/certdump.c | |
| parent | scd:p15: Support signing with CardOS 5 cards. (diff) | |
| download | gnupg2-c7ff8c59b9252f8f27cabee3fea503f06c7d46ff.tar.xz gnupg2-c7ff8c59b9252f8f27cabee3fea503f06c7d46ff.zip | |
sm: Fix a warning in an es_fopencooie function.
* sm/certdump.c (format_name_writer): Take care of a flush request.
--
We won't see a flush here so that fix does not solve a real bug but we
want to be correct. Note that this function seems to predate the
es_fopenmem function and thus in master (2.3) we should replace it
entirely.
GnuPG-bug-id: 4495
Signed-off-by: Werner Koch <wk@gnupg.org>
(cherry picked from 2.2 commit 8d0d61aca3d2713df8a33444af3658b859d72be8)
Diffstat (limited to 'sm/certdump.c')
| -rw-r--r-- | sm/certdump.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sm/certdump.c b/sm/certdump.c index 9567c67f5..ef60358d7 100644 --- a/sm/certdump.c +++ b/sm/certdump.c @@ -658,6 +658,10 @@ format_name_writer (void *cookie, const void *buffer, size_t size) struct format_name_cookie *c = cookie; char *p; + /* FIXME: Replace the whole thing using es_fopenmem based code. */ + if (!buffer) /* Flush. */ + return 0; /* (Actually we could use SIZE because that should be 0 too.) */ + if (!c->buffer) { p = xtrymalloc (size + 1 + 1); |