[#151] Addressed comments

12 files changed, 5 insertions, 12 deletions

diff --git a/src/bin/agent/agent_lexer.ll b/src/bin/agent/agent_lexer.ll
index 0ec041638f..fec84bee53 100644
--- a/src/bin/agent/agent_lexer.ll
+++ b/src/bin/agent/agent_lexer.ll
@@ -648,7 +648,7 @@ ControlCharacterFill            [^"\\]|\\["\\/bfnrtu]
     /* Bad string with an open unicode escape at the end */
     std::string raw(yytext+1);
     size_t pos = raw.size() - 1;
-    for (; pos >= 0; --pos) {
+    for (; pos > 0; --pos) {
         char c = raw[pos];
         if (c == 'u') {
             break;
diff --git a/src/bin/agent/parser_context.cc b/src/bin/agent/parser_context.cc
index c94a9422bf..18b2586e03 100644
--- a/src/bin/agent/parser_context.cc
+++ b/src/bin/agent/parser_context.cc
@@ -68,7 +68,6 @@ ParserContext::parseCommon() {
     }
 }
 
-
 void
 ParserContext::error(const isc::agent::location& loc,
                      const std::string& what,
diff --git a/src/bin/d2/d2_lexer.ll b/src/bin/d2/d2_lexer.ll
index ae8f13807a..e484aeebf7 100644
--- a/src/bin/d2/d2_lexer.ll
+++ b/src/bin/d2/d2_lexer.ll
@@ -692,7 +692,7 @@ ControlCharacterFill            [^"\\]|\\["\\/bfnrtu]
     /* Bad string with an open unicode escape at the end */
     std::string raw(yytext+1);
     size_t pos = raw.size() - 1;
-    for (; pos >= 0; --pos) {
+    for (; pos > 0; --pos) {
         char c = raw[pos];
         if (c == 'u') {
             break;
diff --git a/src/bin/d2/parser_context.cc b/src/bin/d2/parser_context.cc
index f0b1ceaf4d..fce0c9f79b 100644
--- a/src/bin/d2/parser_context.cc
+++ b/src/bin/d2/parser_context.cc
@@ -64,7 +64,6 @@ D2ParserContext::parseCommon() {
     }
 }
 
-
 void
 D2ParserContext::error(const isc::d2::location& loc,
                        const std::string& what,
diff --git a/src/bin/d2/parser_context.h b/src/bin/d2/parser_context.h
index 7912615a03..0d596cf56f 100644
--- a/src/bin/d2/parser_context.h
+++ b/src/bin/d2/parser_context.h
@@ -31,7 +31,6 @@ public:
         isc::Exception(file, line, what) { };
 };
 
-
 /// @brief Evaluation context, an interface to the expression evaluation.
 class D2ParserContext
 {
diff --git a/src/bin/dhcp4/dhcp4_lexer.ll b/src/bin/dhcp4/dhcp4_lexer.ll
index dd6eaf651b..e1b1f1ba32 100644
--- a/src/bin/dhcp4/dhcp4_lexer.ll
+++ b/src/bin/dhcp4/dhcp4_lexer.ll
@@ -2078,7 +2078,7 @@ ControlCharacterFill            [^"\\]|\\["\\/bfnrtu]
     /* Bad string with an open unicode escape at the end */
     std::string raw(yytext+1);
     size_t pos = raw.size() - 1;
-    for (; pos >= 0; --pos) {
+    for (; pos > 0; --pos) {
         char c = raw[pos];
         if (c == 'u') {
             break;
diff --git a/src/bin/dhcp4/parser_context.cc b/src/bin/dhcp4/parser_context.cc
index c6052a775b..fcbb91fbb4 100644
--- a/src/bin/dhcp4/parser_context.cc
+++ b/src/bin/dhcp4/parser_context.cc
@@ -68,7 +68,6 @@ Parser4Context::parseCommon() {
     }
 }
 
-
 void
 Parser4Context::error(const isc::dhcp::location& loc,
                       const std::string& what,
diff --git a/src/bin/dhcp4/parser_context.h b/src/bin/dhcp4/parser_context.h
index 04dabbaba9..e87f4732e7 100644
--- a/src/bin/dhcp4/parser_context.h
+++ b/src/bin/dhcp4/parser_context.h
@@ -31,7 +31,6 @@ public:
         isc::Exception(file, line, what) { };
 };
 
-
 /// @brief Evaluation context, an interface to the expression evaluation.
 class Parser4Context
 {
diff --git a/src/bin/dhcp6/dhcp6_lexer.ll b/src/bin/dhcp6/dhcp6_lexer.ll
index 20a4e29fe7..99b61cb0b3 100644
--- a/src/bin/dhcp6/dhcp6_lexer.ll
+++ b/src/bin/dhcp6/dhcp6_lexer.ll
@@ -2140,7 +2140,7 @@ ControlCharacterFill            [^"\\]|\\["\\/bfnrtu]
     /* Bad string with an open unicode escape at the end */
     std::string raw(yytext+1);
     size_t pos = raw.size() - 1;
-    for (; pos >= 0; --pos) {
+    for (; pos > 0; --pos) {
         char c = raw[pos];
         if (c == 'u') {
             break;
diff --git a/src/bin/dhcp6/parser_context.h b/src/bin/dhcp6/parser_context.h
index 06d1d6aa26..e95b12949e 100644
--- a/src/bin/dhcp6/parser_context.h
+++ b/src/bin/dhcp6/parser_context.h
@@ -31,7 +31,6 @@ public:
         isc::Exception(file, line, what) { };
 };
 
-
 /// @brief Evaluation context, an interface to the expression evaluation.
 class Parser6Context
 {
diff --git a/src/bin/netconf/netconf_lexer.ll b/src/bin/netconf/netconf_lexer.ll
index 19c8dcda5b..5f056a6f5f 100644
--- a/src/bin/netconf/netconf_lexer.ll
+++ b/src/bin/netconf/netconf_lexer.ll
@@ -649,7 +649,7 @@ ControlCharacterFill            [^"\\]|\\["\\/bfnrtu]
     /* Bad string with an open unicode escape at the end */
     std::string raw(yytext+1);
     size_t pos = raw.size() - 1;
-    for (; pos >= 0; --pos) {
+    for (; pos > 0; --pos) {
         char c = raw[pos];
         if (c == 'u') {
             break;
diff --git a/src/bin/netconf/parser_context.cc b/src/bin/netconf/parser_context.cc
index 9726672fbf..24fc650407 100644
--- a/src/bin/netconf/parser_context.cc
+++ b/src/bin/netconf/parser_context.cc
@@ -68,7 +68,6 @@ ParserContext::parseCommon() {
     }
 }
 
-
 void
 ParserContext::error(const isc::netconf::location& loc,
                      const std::string& what,