[3546] Another changes after review:

 - (offset - 4) explained better
 - Modified Dhcpv6Srv::unpackOptions()
 - setHWAddrMember() mac_addr renamed (this time for real)
 - Commented out unused variables
 - RelayInfo now uses DEFAULT_ADDRESS6 in ctor
 - LibDHCP::unpackOptions6 and callback now used uniformly
 - Clarified that ERO is Echo Request Option (RFC4994)
 - unpackOptions4 in libdhcp and Dhcp4Srv no longer throw when
   truncated option is received.

1 files changed, 2 insertions, 4 deletions

diff --git a/src/lib/dhcp/tests/pkt6_unittest.cc b/src/lib/dhcp/tests/pkt6_unittest.cc
index 3cfaff9237..3fc25d3324 100644
--- a/src/lib/dhcp/tests/pkt6_unittest.cc
+++ b/src/lib/dhcp/tests/pkt6_unittest.cc
@@ -354,7 +354,8 @@ TEST_F(Pkt6Test, unpackMalformed) {
     EXPECT_NO_THROW(trailing_garbage->unpack());
 
     // A strict approach would assume the code will reject the whole packet,
-    // but we decided to follow Jon Postel's law.
+    // but we decided to follow Jon Postel's law and be silent about
+    // received malformed or truncated options.
 
     // Add an option that is truncated
     OptionBuffer malform2 = orig;
@@ -371,9 +372,6 @@ TEST_F(Pkt6Test, unpackMalformed) {
 
     // ... but there should be no option 123 as it was malformed.
     EXPECT_FALSE(trunc_option->getOption(123));
-
-    // A strict approach would assume the code will reject the whole packet,
-    // but we decided to follow Jon Postel's law.
 }
 
 // This test verifies that it is possible to specify custom implementation of