From 83ca9a47dc1e4ed1afa539174d85f697e5b757c6 Mon Sep 17 00:00:00 2001 From: Mukund Sivaraman Date: Thu, 20 Feb 2014 08:38:09 +0530 Subject: [2534] Update CAA unittest to match change in string token scanning behavior --- src/lib/dns/tests/rdata_caa_unittest.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'src/lib/dns/tests/rdata_caa_unittest.cc') diff --git a/src/lib/dns/tests/rdata_caa_unittest.cc b/src/lib/dns/tests/rdata_caa_unittest.cc index b88aba31e7..8000005d16 100644 --- a/src/lib/dns/tests/rdata_caa_unittest.cc +++ b/src/lib/dns/tests/rdata_caa_unittest.cc @@ -127,9 +127,10 @@ TEST_F(Rdata_CAA_Test, fields) { EXPECT_THROW(const generic::CAA rdata_caa2("256 issue \"ca.example.net\""), InvalidRdataText); - // Missing tag actually passes because it parses the value as tag - // and assumes that the value is empty instead. - EXPECT_NO_THROW(const generic::CAA rdata_caa2("0 \"ca.example.net\"")); + // Missing tag causes the value to be parsed as the tag field. As + // the tag field does not allow quoted strings, this throws. + EXPECT_THROW(const generic::CAA rdata_caa2("0 \"ca.example.net\""), + InvalidRdataText); // Tag is too long const std::string tag(256, 'a'); -- cgit v1.2.3