diff options
author | Arnd Bergmann <arnd@arndb.de> | 2017-01-13 16:40:01 +0100 |
---|---|---|
committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2017-03-16 18:48:42 +0100 |
commit | b334e19ae9381f12a7521976883022385d2b7eef (patch) | |
tree | f7a9ef0bcbf1275f1dadc4f0ad867ae1a7a656c7 /.cocciconfig | |
parent | kbuild: external module build warnings when KBUILD_OUTPUT set and W=1 (diff) | |
download | linux-b334e19ae9381f12a7521976883022385d2b7eef.tar.xz linux-b334e19ae9381f12a7521976883022385d2b7eef.zip |
Kbuild: use cc-disable-warning consistently for maybe-uninitialized
In commit a76bcf557ef4 ("Kbuild: enable -Wmaybe-uninitialized warning
for "make W=1""), I reverted another change that happened to fix a problem
with old compilers, and now we get this report again with old compilers
(prior to gcc-4.8) and GCOV enabled:
cc1: warnings being treated as errors
drivers/gpu/drm/i915/intel_ringbuffer.c: In function 'intel_ring_setup_status_page':
drivers/gpu/drm/i915/intel_ringbuffer.c:438: error: 'mmio.reg' may be used uninitialized in this function
At top level:
>> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
The problem is that we turn off the warning conditionally in a number
of places as we should, but one of them does it unconditionally.
Instead, change it to call cc-disable-warning as we do elsewhere.
The original patch that caused it was merged into linux-4.7, then
4.8 removed the change and 4.9 brought it back, so we probably want
a backport to 4.9 once this is merged.
Use a ':=' assignment instead of '=' to force the cc-disable-warning
call to only be evaluated once instead of every time.
Cc: stable@vger.kernel.org
Fixes: a76bcf557ef4 ("Kbuild: enable -Wmaybe-uninitialized warning for "make W=1"")
Fixes: e72e2dfe7c16 ("gcov: disable -Wmaybe-uninitialized warning")
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Diffstat (limited to '.cocciconfig')
0 files changed, 0 insertions, 0 deletions