diff options
author | Sava Jakovljev <savaj@meyersound.com> | 2024-08-21 04:16:57 +0200 |
---|---|---|
committer | Paolo Abeni <pabeni@redhat.com> | 2024-08-22 13:00:05 +0200 |
commit | a2f5c505b4378cd6fc7c4a44ff3665ccef2037db (patch) | |
tree | ba67c64bddcf231ddb64043030357ba4174c59ce /.gitattributes | |
parent | net: ngbe: Fix phy mode set to external phy (diff) | |
download | linux-a2f5c505b4378cd6fc7c4a44ff3665ccef2037db.tar.xz linux-a2f5c505b4378cd6fc7c4a44ff3665ccef2037db.zip |
net: phy: realtek: Fix setting of PHY LEDs Mode B bit on RTL8211F
The current implementation incorrectly sets the mode bit of the PHY chip.
Bit 15 (RTL8211F_LEDCR_MODE) should not be shifted together with the
configuration nibble of a LED- it should be set independently of the
index of the LED being configured.
As a consequence, the RTL8211F LED control is actually operating in Mode A.
Fix the error by or-ing final register value to write with a const-value of
RTL8211F_LEDCR_MODE, thus setting Mode bit explicitly.
Fixes: 17784801d888 ("net: phy: realtek: Add support for PHY LEDs on RTL8211F")
Signed-off-by: Sava Jakovljev <savaj@meyersound.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Link: https://patch.msgid.link/PAWP192MB21287372F30C4E55B6DF6158C38E2@PAWP192MB2128.EURP192.PROD.OUTLOOK.COM
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to '.gitattributes')
0 files changed, 0 insertions, 0 deletions