diff options
author | Reinette Chatre <reinette.chatre@intel.com> | 2022-02-02 20:41:12 +0100 |
---|---|---|
committer | Dave Hansen <dave.hansen@linux.intel.com> | 2022-02-17 19:24:50 +0100 |
commit | e5733d8c89c3b57c8fcd40b8acf508388fabaa42 (patch) | |
tree | 5446223bcbf580ed0cfb60b3a6c052b10bc28faf /.gitignore | |
parent | x86/sgx: Silence softlockup detection when releasing large enclaves (diff) | |
download | linux-e5733d8c89c3b57c8fcd40b8acf508388fabaa42.tar.xz linux-e5733d8c89c3b57c8fcd40b8acf508388fabaa42.zip |
x86/sgx: Fix missing poison handling in reclaimer
The SGX reclaimer code lacks page poison handling in its main
free path. This can lead to avoidable machine checks if a
poisoned page is freed and reallocated instead of being
isolated.
A troublesome scenario is:
1. Machine check (#MC) occurs (asynchronous, !MF_ACTION_REQUIRED)
2. arch_memory_failure() is eventually called
3. (SGX) page->poison set to 1
4. Page is reclaimed
5. Page added to normal free lists by sgx_reclaim_pages()
^ This is the bug (poison pages should be isolated on the
sgx_poison_page_list instead)
6. Page is reallocated by some innocent enclave, a second (synchronous)
in-kernel #MC is induced, probably during EADD instruction.
^ This is the fallout from the bug
(6) is unfortunate and can be avoided by replacing the open coded
enclave page freeing code in the reclaimer with sgx_free_epc_page()
to obtain support for poison page handling that includes placing the
poisoned page on the correct list.
Fixes: d6d261bded8a ("x86/sgx: Add new sgx_epc_page flag bit to mark free pages")
Fixes: 992801ae9243 ("x86/sgx: Initial poison handling for dirty and free pages")
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Link: https://lkml.kernel.org/r/dcc95eb2aaefb042527ac50d0a50738c7c160dac.1643830353.git.reinette.chatre@intel.com
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions