diff options
author | Matthieu Baerts (NGI0) <matttbe@kernel.org> | 2024-08-19 21:45:25 +0200 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2024-08-21 02:40:12 +0200 |
commit | f448451aa62d54be16acb0034223c17e0d12bc69 (patch) | |
tree | 95aac6ac7c7da1b1bead77960aaa38fb9e9d005c /.mailmap | |
parent | selftests: mptcp: join: test for flush/re-add endpoints (diff) | |
download | linux-f448451aa62d54be16acb0034223c17e0d12bc69.tar.xz linux-f448451aa62d54be16acb0034223c17e0d12bc69.zip |
mptcp: pm: remove mptcp_pm_remove_subflow()
This helper is confusing. It is in pm.c, but it is specific to the
in-kernel PM and it cannot be used by the userspace one. Also, it simply
calls one in-kernel specific function with the PM lock, while the
similar mptcp_pm_remove_addr() helper requires the PM lock.
What's left is the pr_debug(), which is not that useful, because a
similar one is present in the only function called by this helper:
mptcp_pm_nl_rm_subflow_received()
After these modifications, this helper can be marked as 'static', and
the lock can be taken only once in mptcp_pm_flush_addrs_and_subflows().
Note that it is not a bug fix, but it will help backporting the
following commits.
Fixes: 0ee4261a3681 ("mptcp: implement mptcp_pm_remove_subflow")
Cc: stable@vger.kernel.org
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20240819-net-mptcp-pm-reusing-id-v1-7-38035d40de5b@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to '.mailmap')
0 files changed, 0 insertions, 0 deletions