diff options
| author | Kim, Milo <Milo.Kim@ti.com> | 2013-02-22 01:44:07 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-02-22 02:22:25 +0100 |
| commit | 9e9cdc89695d04359e2d67521199156549c12eb4 (patch) | |
| tree | ef138967a9b80c34f6c3c73ad194250bfa9520a8 | |
| parent | backlight: lp855x_bl: support new LP8557 device (diff) | |
| download | linux-9e9cdc89695d04359e2d67521199156549c12eb4.tar.xz linux-9e9cdc89695d04359e2d67521199156549c12eb4.zip | |
backlight: lp855x_bl: simplify bl_get_brightness()
Getting the brightness value is not critical, no need to read the actual
register value. To simplify it, just return the 'bl->props.brightness'
value. Then, lp855x_read_byte() can be removed, not used any more.
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/video/backlight/lp855x_bl.c | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c index edd2041b1527..7ae9ae6f4655 100644 --- a/drivers/video/backlight/lp855x_bl.c +++ b/drivers/video/backlight/lp855x_bl.c @@ -66,20 +66,6 @@ struct lp855x { struct pwm_device *pwm; }; -static int lp855x_read_byte(struct lp855x *lp, u8 reg, u8 *data) -{ - int ret; - - ret = i2c_smbus_read_byte_data(lp->client, reg); - if (ret < 0) { - dev_err(lp->dev, "failed to read 0x%.2x\n", reg); - return ret; - } - - *data = (u8)ret; - return 0; -} - static int lp855x_write_byte(struct lp855x *lp, u8 reg, u8 data) { return i2c_smbus_write_byte_data(lp->client, reg, data); @@ -274,16 +260,6 @@ static int lp855x_bl_update_status(struct backlight_device *bl) static int lp855x_bl_get_brightness(struct backlight_device *bl) { - struct lp855x *lp = bl_get_data(bl); - enum lp855x_brightness_ctrl_mode mode = lp->pdata->mode; - - if (mode == REGISTER_BASED) { - u8 val = 0; - - lp855x_read_byte(lp, lp->cfg->reg_brightness, &val); - bl->props.brightness = val; - } - return bl->props.brightness; } |