diff options
| author | Sarah Sharp <sarah.a.sharp@linux.intel.com> | 2012-10-16 22:26:22 +0200 |
|---|---|---|
| committer | Sarah Sharp <sarah.a.sharp@linux.intel.com> | 2012-10-25 22:13:48 +0200 |
| commit | b80313422a1551cc1d4f3e2d532fe633154ae5dd (patch) | |
| tree | 1b5ec47e20e17eeeaa11e52831e1c7e047ae70e4 | |
| parent | xhci: Fix potential NULL ptr deref in command cancellation. (diff) | |
| download | linux-b80313422a1551cc1d4f3e2d532fe633154ae5dd.tar.xz linux-b80313422a1551cc1d4f3e2d532fe633154ae5dd.zip | |
xhci: Fix missing break in xhci_evaluate_context_result.
Coverity complains that xhci_evaluate_context_result() is missing a
break statement after the COMP_EBADSLT switch case. It's not a big
deal, since we wanted to return the same error code as the case
statement below it does. The end result would be one that a Slot
Disabled error completion code would also print the warning message
associated with a Context State error code. No other bad behavior would
result.
It's not worth backporting to stable kernels, since it only fixes an
issue with too much debugging.
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/usb/host/xhci.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 9ec939646b42..ffe2e2e5c6ab 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -1817,6 +1817,8 @@ static int xhci_evaluate_context_result(struct xhci_hcd *xhci, case COMP_EBADSLT: dev_warn(&udev->dev, "WARN: slot not enabled for" "evaluate context command.\n"); + ret = -EINVAL; + break; case COMP_CTX_STATE: dev_warn(&udev->dev, "WARN: invalid context state for " "evaluate context command.\n"); |