diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2017-04-25 09:49:22 +0200 |
|---|---|---|
| committer | Sebastian Reichel <sre@kernel.org> | 2017-06-08 13:21:43 +0200 |
| commit | 1be0593f05e25d56a8f65586ea6d9afa601743bc (patch) | |
| tree | d47aa5ac517415aaa6b19537e21a58c71fbdeaf2 | |
| parent | Linux 4.12-rc1 (diff) | |
| download | linux-1be0593f05e25d56a8f65586ea6d9afa601743bc.tar.xz linux-1be0593f05e25d56a8f65586ea6d9afa601743bc.zip | |
HSI: nokia-modem: Use devm_kcalloc() in nokia_modem_gpio_probe()
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "devm_kcalloc".
This issue was detected by using the Coccinelle software.
* Replace the specification of a data structure by a pointer dereference
to make the corresponding size determination a bit safer according to
the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Diffstat (limited to '')
| -rw-r--r-- | drivers/hsi/clients/nokia-modem.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hsi/clients/nokia-modem.c b/drivers/hsi/clients/nokia-modem.c index c000780d931f..f6c97a0e1fcd 100644 --- a/drivers/hsi/clients/nokia-modem.c +++ b/drivers/hsi/clients/nokia-modem.c @@ -102,8 +102,8 @@ static int nokia_modem_gpio_probe(struct device *dev) return -EINVAL; } - modem->gpios = devm_kzalloc(dev, gpio_count * - sizeof(struct nokia_modem_gpio), GFP_KERNEL); + modem->gpios = devm_kcalloc(dev, gpio_count, sizeof(*modem->gpios), + GFP_KERNEL); if (!modem->gpios) { dev_err(dev, "Could not allocate memory for gpios\n"); return -ENOMEM; |