summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Richter <stefanr@s5r6.in-berlin.de>2008-03-08 22:38:16 +0100
committerStefan Richter <stefanr@s5r6.in-berlin.de>2008-03-14 00:56:59 +0100
commita2cdebe33f4c40a1bc7f66522303df89d5026cb4 (patch)
treeed8e37d57d94242c799ca5d47c8e7700e4b79973
parentfirewire: fw-sbp2: set single-phase retry_limit (diff)
downloadlinux-a2cdebe33f4c40a1bc7f66522303df89d5026cb4.tar.xz
linux-a2cdebe33f4c40a1bc7f66522303df89d5026cb4.zip
firewire: warn on fatal condition in topology code
If this ever happens to anybody, we want to have it in his log. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
-rw-r--r--drivers/firewire/fw-topology.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/firewire/fw-topology.c b/drivers/firewire/fw-topology.c
index e47bb040197a..d2c7a3d7e1cb 100644
--- a/drivers/firewire/fw-topology.c
+++ b/drivers/firewire/fw-topology.c
@@ -21,6 +21,7 @@
#include <linux/module.h>
#include <linux/wait.h>
#include <linux/errno.h>
+#include <asm/bug.h>
#include <asm/system.h>
#include "fw-transaction.h"
#include "fw-topology.h"
@@ -424,8 +425,8 @@ update_tree(struct fw_card *card, struct fw_node *root)
node1 = fw_node(list1.next);
while (&node0->link != &list0) {
+ WARN_ON(node0->port_count != node1->port_count);
- /* assert(node0->port_count == node1->port_count); */
if (node0->link_on && !node1->link_on)
event = FW_NODE_LINK_OFF;
else if (!node0->link_on && node1->link_on)