summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBob Copeland <me@bobcopeland.com>2009-04-28 04:12:43 +0200
committerJohn W. Linville <linville@tuxdriver.com>2009-04-28 21:59:48 +0200
commitb7fcb5c4a4c27da2f6d86cb03d18687e537442cf (patch)
tree45848311dcd1dd1a116edc48d18586825d7c047a
parentiwlwifi: notify on scan completion even when shutting down (diff)
downloadlinux-b7fcb5c4a4c27da2f6d86cb03d18687e537442cf.tar.xz
linux-b7fcb5c4a4c27da2f6d86cb03d18687e537442cf.zip
ath5k: fix buffer overrun in rate debug code
char bname[5] is too small for the string "X GHz" when the null terminator is taken into account. Thus, turning on rate debugging can crash unless we have lucky stack alignment. Cc: stable@kernel.org Reported-by: Paride Legovini <legovini@spiro.fisica.unipd.it> Signed-off-by: Bob Copeland <me@bobcopeland.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--drivers/net/wireless/ath5k/debug.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/ath5k/debug.c b/drivers/net/wireless/ath5k/debug.c
index 9770bb3d40f9..4904a07e4b59 100644
--- a/drivers/net/wireless/ath5k/debug.c
+++ b/drivers/net/wireless/ath5k/debug.c
@@ -424,7 +424,7 @@ ath5k_debug_dump_bands(struct ath5k_softc *sc)
for (b = 0; b < IEEE80211_NUM_BANDS; b++) {
struct ieee80211_supported_band *band = &sc->sbands[b];
- char bname[5];
+ char bname[6];
switch (band->band) {
case IEEE80211_BAND_2GHZ:
strcpy(bname, "2 GHz");