diff options
| author | Oleg Nesterov <oleg@tv-sign.ru> | 2006-03-18 18:41:10 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-18 19:49:36 +0100 |
| commit | 2d61b86775a5676a8fba2ba2f0f869564e35c630 (patch) | |
| tree | afdb967ec1bb3ddd212acdd8f25675c371f7e6e7 | |
| parent | [NET]: Fix race condition in sk_wait_event(). (diff) | |
| download | linux-2d61b86775a5676a8fba2ba2f0f869564e35c630.tar.xz linux-2d61b86775a5676a8fba2ba2f0f869564e35c630.zip | |
[PATCH] disable unshare(CLONE_VM) for now
sys_unshare() does mmput(new_mm). This is not enough if we have
mm->core_waiters.
This patch is a temporary fix for soon to be released 2.6.16.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
[ Checked with Uli: "I'm not planning to use unshare(CLONE_VM). It's
not needed for any functionality planned so far. What we (as in Red
Hat) need unshare() for now is the filesystem side." ]
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | kernel/fork.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/kernel/fork.c b/kernel/fork.c index 46060cb24af0..b373322ca497 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -1478,9 +1478,7 @@ static int unshare_vm(unsigned long unshare_flags, struct mm_struct **new_mmp) if ((unshare_flags & CLONE_VM) && (mm && atomic_read(&mm->mm_users) > 1)) { - *new_mmp = dup_mm(current); - if (!*new_mmp) - return -ENOMEM; + return -EINVAL; } return 0; |