diff options
author | Sjur Braendeland <sjur.braendeland@stericsson.com> | 2010-09-21 13:44:44 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-09-22 03:05:30 +0200 |
commit | b04367df66eb63444d38c43d15f5e39499d85ae6 (patch) | |
tree | beb31309a5ab2000ad07b92ee4c4e22a6cbc2a90 | |
parent | caif: Remove buggy re-definition of pr_debug (diff) | |
download | linux-b04367df66eb63444d38c43d15f5e39499d85ae6.tar.xz linux-b04367df66eb63444d38c43d15f5e39499d85ae6.zip |
caif: Minor fixes in log prints.
Use pr_debug for flow control printouts, and refine an error printout.
Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/caif/caif_socket.c | 8 | ||||
-rw-r--r-- | net/caif/cfcnfg.c | 2 |
2 files changed, 3 insertions, 7 deletions
diff --git a/net/caif/caif_socket.c b/net/caif/caif_socket.c index fd1f5df0827c..3943398f70cd 100644 --- a/net/caif/caif_socket.c +++ b/net/caif/caif_socket.c @@ -159,9 +159,7 @@ static int caif_queue_rcv_skb(struct sock *sk, struct sk_buff *skb) if (atomic_read(&sk->sk_rmem_alloc) + skb->truesize >= (unsigned)sk->sk_rcvbuf && rx_flow_is_on(cf_sk)) { - trace_printk("CAIF: %s(): " - "sending flow OFF (queue len = %d %d)\n", - __func__, + pr_debug("sending flow OFF (queue len = %d %d)\n", atomic_read(&cf_sk->sk.sk_rmem_alloc), sk_rcvbuf_lowwater(cf_sk)); set_rx_flow_off(cf_sk); @@ -174,9 +172,7 @@ static int caif_queue_rcv_skb(struct sock *sk, struct sk_buff *skb) return err; if (!sk_rmem_schedule(sk, skb->truesize) && rx_flow_is_on(cf_sk)) { set_rx_flow_off(cf_sk); - trace_printk("CAIF: %s(): " - "sending flow OFF due to rmem_schedule\n", - __func__); + pr_debug("sending flow OFF due to rmem_schedule\n"); dbfs_atomic_inc(&cnt.num_rx_flow_off); caif_flow_ctrl(sk, CAIF_MODEMCMD_FLOW_OFF_REQ); } diff --git a/net/caif/cfcnfg.c b/net/caif/cfcnfg.c index ef93a131310b..41adafd18914 100644 --- a/net/caif/cfcnfg.c +++ b/net/caif/cfcnfg.c @@ -197,7 +197,7 @@ int cfcnfg_disconn_adapt_layer(struct cfcnfg *cnfg, struct cflayer *adap_layer) caif_assert(adap_layer != NULL); channel_id = adap_layer->id; if (adap_layer->dn == NULL || channel_id == 0) { - pr_err("adap_layer->id is 0\n"); + pr_err("adap_layer->dn == NULL or adap_layer->id is 0\n"); ret = -ENOTCONN; goto end; } |