summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAl Viro <viro@ZenIV.linux.org.uk>2011-06-05 02:54:03 +0200
committerDavid S. Miller <davem@davemloft.net>2011-06-05 23:11:09 +0200
commitb8f07a063163f8216cd891c5b007e839a56b6d93 (patch)
tree83cd31339371ab707d29e1275633baf4d3db2a65
parentget_net_ns_by_fd() oopses if proc_ns_fget() returns an error (diff)
downloadlinux-b8f07a063163f8216cd891c5b007e839a56b6d93.tar.xz
linux-b8f07a063163f8216cd891c5b007e839a56b6d93.zip
fix return values of l2tp_dfs_seq_open()
More fallout from struct net lifetime rules review: PTR_ERR() is *already* negative and failing ->open() should return negatives on failure. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: James Chapman <jchapman@katalix.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/l2tp/l2tp_debugfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/l2tp/l2tp_debugfs.c b/net/l2tp/l2tp_debugfs.c
index b8dbae82fab8..76130134bfa6 100644
--- a/net/l2tp/l2tp_debugfs.c
+++ b/net/l2tp/l2tp_debugfs.c
@@ -258,7 +258,7 @@ static int l2tp_dfs_seq_open(struct inode *inode, struct file *file)
*/
pd->net = get_net_ns_by_pid(current->pid);
if (IS_ERR(pd->net)) {
- rc = -PTR_ERR(pd->net);
+ rc = PTR_ERR(pd->net);
goto err_free_pd;
}