summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJiri Slaby <jslaby@suse.cz>2011-02-28 10:34:06 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2011-03-01 04:24:54 +0100
commit6960f40a954619857e7095a6179eef896f297077 (patch)
tree57d7c5e0177399c5aa92bec9b1510dfcc6b2d684
parentUSB: serial/keyspan_pda, fix potential tty NULL dereferences (diff)
downloadlinux-6960f40a954619857e7095a6179eef896f297077.tar.xz
linux-6960f40a954619857e7095a6179eef896f297077.zip
USB: serial/kobil_sct, fix potential tty NULL dereference
Make sure that we check the return value of tty_port_tty_get. Sometimes it may return NULL and we later dereference that. The only place here is in kobil_read_int_callback, so fix it. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Alan Cox <alan@linux.intel.com> Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/serial/kobil_sct.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
index bd5bd8589e04..b382d9a0274d 100644
--- a/drivers/usb/serial/kobil_sct.c
+++ b/drivers/usb/serial/kobil_sct.c
@@ -372,7 +372,7 @@ static void kobil_read_int_callback(struct urb *urb)
}
tty = tty_port_tty_get(&port->port);
- if (urb->actual_length) {
+ if (tty && urb->actual_length) {
/* BEGIN DEBUG */
/*