diff options
author | Simon Guinot <sguinot@lacie.com> | 2010-09-17 23:33:51 +0200 |
---|---|---|
committer | Nicolas Pitre <nico@fluxnic.net> | 2010-09-20 04:43:41 +0200 |
commit | 863636828f1fcd9fdc15e24d620aa53cf18b432f (patch) | |
tree | e49e40a35fd5b72b232c45f451667b723c6a79c0 | |
parent | ARM: kirkwood: Unbreak PCIe I/O port (diff) | |
download | linux-863636828f1fcd9fdc15e24d620aa53cf18b432f.tar.xz linux-863636828f1fcd9fdc15e24d620aa53cf18b432f.zip |
dmaengine: fix interrupt clearing for mv_xor
When using simultaneously the two DMA channels on a same engine, some
transfers are never completed. For example, an endless lock can occur
while writing heavily on a RAID5 array (with async-tx offload support
enabled).
Note that this issue can also be reproduced by using the DMA test
client.
On a same engine, the interrupt cause register is shared between two
DMA channels. This patch make sure that the cause bit is only cleared
for the requested channel.
Signed-off-by: Simon Guinot <sguinot@lacie.com>
Tested-by: Luc Saillard <luc@saillard.org>
Acked-by: Saeed Bishara <saeed@marvell.com>
Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
-rw-r--r-- | drivers/dma/mv_xor.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index 86c5ae9fde34..411d5bf50fc4 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -162,7 +162,7 @@ static int mv_is_err_intr(u32 intr_cause) static void mv_xor_device_clear_eoc_cause(struct mv_xor_chan *chan) { - u32 val = (1 << (1 + (chan->idx * 16))); + u32 val = ~(1 << (chan->idx * 16)); dev_dbg(chan->device->common.dev, "%s, val 0x%08x\n", __func__, val); __raw_writel(val, XOR_INTR_CAUSE(chan)); } |