diff options
| author | Marek Vasut <marek.vasut@gmail.com> | 2011-07-26 18:44:47 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-07-28 07:39:31 +0200 |
| commit | bca0beb9363f8487ac902931a50eb00180a2d14a (patch) | |
| tree | f7c87ac7a9f8c055a883c695ad8c8b0db336edd6 | |
| parent | ASIX: Simplify condition in rx_fixup() (diff) | |
| download | linux-bca0beb9363f8487ac902931a50eb00180a2d14a.tar.xz linux-bca0beb9363f8487ac902931a50eb00180a2d14a.zip | |
ASIX: Use only 11 bits of header for data size
The AX88772B uses only 11 bits of the header for the actual size. The other bits
are used for something else. This causes dmesg full of messages:
asix_rx_fixup() Bad Header Length
This patch trims the check to only 11 bits. I believe on older chips, the
remaining 5 top bits are unused.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/usb/asix.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c index d5b62a463401..c5c4b4def7fb 100644 --- a/drivers/net/usb/asix.c +++ b/drivers/net/usb/asix.c @@ -314,11 +314,11 @@ static int asix_rx_fixup(struct usbnet *dev, struct sk_buff *skb) skb_pull(skb, 4); while (skb->len > 0) { - if ((header & 0xffff) != ((~header >> 16) & 0xffff)) + if ((header & 0x07ff) != ((~header >> 16) & 0x07ff)) netdev_err(dev->net, "asix_rx_fixup() Bad Header Length\n"); /* get the packet length */ - size = (u16) (header & 0x0000ffff); + size = (u16) (header & 0x000007ff); if ((skb->len) - ((size + 1) & 0xfffe) == 0) { u8 alignment = (unsigned long)skb->data & 0x3; |