summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBob Moore <robert.moore@intel.com>2009-09-03 03:55:40 +0200
committerLen Brown <len.brown@intel.com>2009-09-09 04:28:33 +0200
commit307a042416dfc2216251a85b79e8578b65fdc0e7 (patch)
tree917923b931b3fc2fa6da212169d1758e2d39d3bf
parentACPI: fix NULL bug for HID/UID string (diff)
downloadlinux-307a042416dfc2216251a85b79e8578b65fdc0e7.tar.xz
linux-307a042416dfc2216251a85b79e8578b65fdc0e7.zip
ACPICA: Fix extraneous warning if _DSM returns a package
_DSM can return any type of object, so validation on the return type cannot be performed. ACPICA BZ 802. http://www.acpica.org/bugzilla/show_bug.cgi?id=802 Signed-off-by: Bob Moore <robert.moore@intel.com> Signed-off-by: Lin Ming <ming.m.lin@intel.com> Signed-off-by: Len Brown <len.brown@intel.com>
-rw-r--r--drivers/acpi/acpica/nspredef.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/acpi/acpica/nspredef.c b/drivers/acpi/acpica/nspredef.c
index 8314e6a9e726..f8427afeebdf 100644
--- a/drivers/acpi/acpica/nspredef.c
+++ b/drivers/acpi/acpica/nspredef.c
@@ -193,11 +193,15 @@ acpi_ns_check_predefined_names(struct acpi_namespace_node *node,
}
/*
- * We have a return value, but if one wasn't expected, just exit, this is
+ * 1) We have a return value, but if one wasn't expected, just exit, this is
* not a problem. For example, if the "Implicit Return" feature is
* enabled, methods will always return a value.
+ *
+ * 2) If the return value can be of any type, then we cannot perform any
+ * validation, exit.
*/
- if (!predefined->info.expected_btypes) {
+ if ((!predefined->info.expected_btypes) ||
+ (predefined->info.expected_btypes == ACPI_RTYPE_ALL)) {
goto cleanup;
}