diff options
| author | Theodore Ts'o <tytso@mit.edu> | 2009-02-28 06:08:53 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2009-02-28 06:08:53 +0100 |
| commit | 8b1a8ff8b321a9384304aeea4dbdb9747daf7ee8 (patch) | |
| tree | 7be11423c5b5a10e085122b5a3e8d004e5fa865a | |
| parent | ext4: Fix deadlock in ext4_write_begin() and ext4_da_write_begin() (diff) | |
| download | linux-8b1a8ff8b321a9384304aeea4dbdb9747daf7ee8.tar.xz linux-8b1a8ff8b321a9384304aeea4dbdb9747daf7ee8.zip | |
ext4: Remove duplicate call to ext4_commit_super() in ext4_freeze()
Commit c4be0c1d added error checking to ext4_freeze() when calling
ext4_commit_super(). Unfortunately the patch failed to remove the
original call to ext4_commit_super(), with the net result that when
freezing the filesystem, the superblock gets written twice, the first
time without error checking.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
| -rw-r--r-- | fs/ext4/super.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index a5732c58f676..39d1993cfa13 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3091,7 +3091,6 @@ static int ext4_freeze(struct super_block *sb) /* Journal blocked and flushed, clear needs_recovery flag. */ EXT4_CLEAR_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER); - ext4_commit_super(sb, EXT4_SB(sb)->s_es, 1); error = ext4_commit_super(sb, EXT4_SB(sb)->s_es, 1); if (error) goto out; |