summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Richter <stefanr@s5r6.in-berlin.de>2006-11-02 21:16:08 +0100
committerStefan Richter <stefanr@s5r6.in-berlin.de>2006-12-07 23:03:38 +0100
commitcd641f68d628e5c44350447d4b8d661991419e60 (patch)
tree55b31092ac650270ca772086fb27a9feab291923
parentieee1394: sbp2: more concise names for types and variables (diff)
downloadlinux-cd641f68d628e5c44350447d4b8d661991419e60.tar.xz
linux-cd641f68d628e5c44350447d4b8d661991419e60.zip
ieee1394: sbp2: use list_move_tail()
It's OK to reorder list_del() and sbp2util_free_command_dma() here. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
-rw-r--r--drivers/ieee1394/sbp2.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c
index a7fb588d3ca7..2b6d9a0fa737 100644
--- a/drivers/ieee1394/sbp2.c
+++ b/drivers/ieee1394/sbp2.c
@@ -619,9 +619,8 @@ static void sbp2util_mark_command_completed(
struct sbp2_lu *lu,
struct sbp2_command_info *cmd)
{
- list_del(&cmd->list);
sbp2util_free_command_dma(cmd);
- list_add_tail(&cmd->list, &lu->cmd_orb_completed);
+ list_move_tail(&cmd->list, &lu->cmd_orb_completed);
}
/*