summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAllan Stephens <Allan.Stephens@windriver.com>2011-01-18 19:58:27 +0100
committerPaul Gortmaker <paul.gortmaker@windriver.com>2011-02-24 00:05:13 +0100
commit9f54b545bd62a42ec354727d90eacadc5846406b (patch)
tree275c8a726f962ce90df0acf10dc619ff468781f2
parenttipc: Clean up tracking of node requesting a broadcast retransmit (diff)
downloadlinux-9f54b545bd62a42ec354727d90eacadc5846406b.tar.xz
linux-9f54b545bd62a42ec354727d90eacadc5846406b.zip
tipc: Eliminate unnecessary locking when starting topology service
Modifies the initialization code for TIPC's topology service to avoid taking the spinlock protecting the subscriber list, since there is no need to do this. Signed-off-by: Allan Stephens <Allan.Stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
-rw-r--r--net/tipc/subscr.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/net/tipc/subscr.c b/net/tipc/subscr.c
index 98ee50b332ae..138737242739 100644
--- a/net/tipc/subscr.c
+++ b/net/tipc/subscr.c
@@ -542,7 +542,6 @@ int tipc_subscr_start(void)
spin_lock_init(&topsrv.lock);
INIT_LIST_HEAD(&topsrv.subscriber_list);
- spin_lock_bh(&topsrv.lock);
res = tipc_createport(NULL,
TIPC_CRITICAL_IMPORTANCE,
NULL,
@@ -563,12 +562,10 @@ int tipc_subscr_start(void)
goto failed;
}
- spin_unlock_bh(&topsrv.lock);
return 0;
failed:
err("Failed to create subscription service\n");
- spin_unlock_bh(&topsrv.lock);
return res;
}