diff options
| author | Stephen Boyd <sboyd@codeaurora.org> | 2012-04-01 08:41:07 +0200 |
|---|---|---|
| committer | Michal Marek <mmarek@suse.cz> | 2012-04-02 11:28:17 +0200 |
| commit | 0eb043d0eec44cd083ea6910b1db2f77eb212ebd (patch) | |
| tree | fae70f3b77368b9f6397b0ebaacf05d5f4a0ce75 | |
| parent | Linux 3.4-rc1 (diff) | |
| download | linux-0eb043d0eec44cd083ea6910b1db2f77eb212ebd.tar.xz linux-0eb043d0eec44cd083ea6910b1db2f77eb212ebd.zip | |
Subject: [PATCH] tags.sh: Add missing quotes
When $remove_structs is empty a test for empty string will turn
into test -n with no arguments meaning true. Add quotes so an
empty string is tested and so that make cscope works again.
Reported-and-tested-by: Jike Song <albcamus@gmail.com>
Reported-by: Prarit Bhargava <prarit@redhat.com>
Acked-by: Yang Bai <hamo.by@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>
| -rwxr-xr-x | scripts/tags.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/tags.sh b/scripts/tags.sh index 0d6004e20658..cf7b12fee573 100755 --- a/scripts/tags.sh +++ b/scripts/tags.sh @@ -254,6 +254,6 @@ case "$1" in esac # Remove structure forward declarations. -if [ -n $remove_structs ]; then +if [ -n "$remove_structs" ]; then LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' $1 fi |