diff options
| author | Patrick McHardy <kaber@trash.net> | 2008-11-24 13:44:55 +0100 |
|---|---|---|
| committer | Patrick McHardy <kaber@trash.net> | 2008-11-24 13:47:21 +0100 |
| commit | 328bd8997dbb7184d5389e45c642af44ae6e9043 (patch) | |
| tree | 92f552084bc34d35472f18fddbd000281640f6af | |
| parent | netfilter: ip{,6}t_policy.h should include xp_policy.h (diff) | |
| download | linux-328bd8997dbb7184d5389e45c642af44ae6e9043.tar.xz linux-328bd8997dbb7184d5389e45c642af44ae6e9043.zip | |
netfilter: nf_conntrack_proto_sctp: avoid bogus warning
net/netfilter/nf_conntrack_proto_sctp.c: In function 'sctp_packet':
net/netfilter/nf_conntrack_proto_sctp.c:376: warning: array subscript is above array bounds
gcc doesn't realize that do_basic_checks() guarantees that there is
at least one valid chunk and thus new_state is never SCTP_CONNTRACK_MAX
after the loop. Initialize to SCTP_CONNTRACK_NONE to avoid the warning.
Based on patch by Wu Fengguang <wfg@linux.intel.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
| -rw-r--r-- | net/netfilter/nf_conntrack_proto_sctp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c index c2bd457bc2f2..74e037901199 100644 --- a/net/netfilter/nf_conntrack_proto_sctp.c +++ b/net/netfilter/nf_conntrack_proto_sctp.c @@ -317,7 +317,7 @@ static int sctp_packet(struct nf_conn *ct, goto out; } - old_state = new_state = SCTP_CONNTRACK_MAX; + old_state = new_state = SCTP_CONNTRACK_NONE; write_lock_bh(&sctp_lock); for_each_sctp_chunk (skb, sch, _sch, offset, dataoff, count) { /* Special cases of Verification tag check (Sec 8.5.1) */ |