diff options
| author | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2011-09-22 22:18:44 +0200 |
|---|---|---|
| committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2011-12-11 19:31:22 +0100 |
| commit | 7077714ec4940a6c5b1189c3afb4f47bf49ad877 (patch) | |
| tree | c8713205a1e6ce6973822bb76ea5e7e1774444ee | |
| parent | rcu: Avoid RCU-preempt expedited grace-period botch (diff) | |
| download | linux-7077714ec4940a6c5b1189c3afb4f47bf49ad877.tar.xz linux-7077714ec4940a6c5b1189c3afb4f47bf49ad877.zip | |
rcu: Make synchronize_sched_expedited() better at work sharing
When synchronize_sched_expedited() takes its second and subsequent
snapshots of sync_sched_expedited_started, it subtracts 1. This
means that the concurrent caller of synchronize_sched_expedited()
that incremented to that value sees our successful completion, it
will not be able to take advantage of it. This restriction is
pointless, given that our full expedited grace period would have
happened after the other guy started, and thus should be able to
serve as a proxy for the other guy successfully executing
try_stop_cpus().
This commit therefore removes the subtraction of 1.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
| -rw-r--r-- | kernel/rcutree_plugin.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h index 798605317161..708dc579634d 100644 --- a/kernel/rcutree_plugin.h +++ b/kernel/rcutree_plugin.h @@ -1910,7 +1910,7 @@ void synchronize_sched_expedited(void) * grace period works for us. */ get_online_cpus(); - snap = atomic_read(&sync_sched_expedited_started) - 1; + snap = atomic_read(&sync_sched_expedited_started); smp_mb(); /* ensure read is before try_stop_cpus(). */ } |