diff options
| author | Roland Dreier <roland@purestorage.com> | 2012-02-14 01:18:16 +0100 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-02-25 23:37:49 +0100 |
| commit | effc6cc8828257c32c37635e737f14fd6e19ecd7 (patch) | |
| tree | 07e44ddcae2a8384bd29faa4565b9c290176ab80 | |
| parent | target: Set peripheral device type consistently in INQUIRY response (diff) | |
| download | linux-effc6cc8828257c32c37635e737f14fd6e19ecd7.tar.xz linux-effc6cc8828257c32c37635e737f14fd6e19ecd7.zip | |
target: Don't set WBUS16 or SYNC bits in INQUIRY response
SPC-4 says about the WBUS16 and SYNC bits:
The meanings of these fields are specific to SPI-5 (see 6.4.3).
For SCSI transport protocols other than the SCSI Parallel
Interface, these fields are reserved.
We don't have a SPI fabric module, so we should never set these bits.
(The comment was misleading, since it only mentioned Sync but the
actual code set WBUS16 too).
Signed-off-by: Roland Dreier <roland@purestorage.com>
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
| -rw-r--r-- | drivers/target/target_core_cdb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/target_core_cdb.c b/drivers/target/target_core_cdb.c index af8ebbde45ea..4f65b258cc25 100644 --- a/drivers/target/target_core_cdb.c +++ b/drivers/target/target_core_cdb.c @@ -95,7 +95,7 @@ target_emulate_inquiry_std(struct se_cmd *cmd, char *buf) if (dev->se_sub_dev->t10_alua.alua_type == SPC3_ALUA_EMULATED) target_fill_alua_data(lun->lun_sep, buf); - buf[7] = 0x32; /* Sync=1 and CmdQue=1 */ + buf[7] = 0x2; /* CmdQue=1 */ snprintf(&buf[8], 8, "LIO-ORG"); snprintf(&buf[16], 16, "%s", dev->se_sub_dev->t10_wwn.model); |