summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJustin Maggard <jmaggard10@gmail.com>2016-10-04 22:17:58 +0200
committerVinod Koul <vinod.koul@intel.com>2016-10-05 02:48:09 +0200
commitc84750906b4818d4929fbf73a4ae6c113b94f52b (patch)
treebd4dc345a73fc9e3685218c12225d72176e1e14b
parentMerge branch 'topic/unmap_cleanup' into for-linus (diff)
downloadlinux-c84750906b4818d4929fbf73a4ae6c113b94f52b.tar.xz
linux-c84750906b4818d4929fbf73a4ae6c113b94f52b.zip
async_pq_val: fix DMA memory leak
Add missing dmaengine_unmap_put(), so we don't OOM during RAID6 sync. Fixes: 1786b943dad0 ("async_pq_val: convert to dmaengine_unmap_data") Signed-off-by: Justin Maggard <jmaggard@netgear.com> Reviewed-by: Dan Williams <dan.j.williams@intel.com> Cc: <stable@vger.kernel.org> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
-rw-r--r--crypto/async_tx/async_pq.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/crypto/async_tx/async_pq.c b/crypto/async_tx/async_pq.c
index 08b3ac68952b..f83de99d7d71 100644
--- a/crypto/async_tx/async_pq.c
+++ b/crypto/async_tx/async_pq.c
@@ -368,8 +368,6 @@ async_syndrome_val(struct page **blocks, unsigned int offset, int disks,
dma_set_unmap(tx, unmap);
async_tx_submit(chan, tx, submit);
-
- return tx;
} else {
struct page *p_src = P(blocks, disks);
struct page *q_src = Q(blocks, disks);
@@ -424,9 +422,11 @@ async_syndrome_val(struct page **blocks, unsigned int offset, int disks,
submit->cb_param = cb_param_orig;
submit->flags = flags_orig;
async_tx_sync_epilog(submit);
-
- return NULL;
+ tx = NULL;
}
+ dmaengine_unmap_put(unmap);
+
+ return tx;
}
EXPORT_SYMBOL_GPL(async_syndrome_val);