summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2008-06-17 12:01:47 +0200
committerDavid S. Miller <davem@davemloft.net>2008-06-17 12:01:47 +0200
commit0efffaf9d57f54a864b739176d1f659a69486e8b (patch)
tree24948ff780a7a44c93daa5736df7e5fdb9706f6b
parentx25: Use sock_graft() and remove bogus sk_socket and sk_sleep init. (diff)
downloadlinux-0efffaf9d57f54a864b739176d1f659a69486e8b.tar.xz
linux-0efffaf9d57f54a864b739176d1f659a69486e8b.zip
econet: Use sock_orphan() instead of open-coded (and buggy) variant.
It doesn't grab the sk_callback_lock, it doesn't NULL out the sk->sk_sleep waitqueue pointer, etc. Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/econet/af_econet.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c
index 7c9bb13b1539..d35127bb84e1 100644
--- a/net/econet/af_econet.c
+++ b/net/econet/af_econet.c
@@ -573,9 +573,7 @@ static int econet_release(struct socket *sock)
sk->sk_state_change(sk); /* It is useless. Just for sanity. */
- sock->sk = NULL;
- sk->sk_socket = NULL;
- sock_set_flag(sk, SOCK_DEAD);
+ sock_orphan(sk);
/* Purge queues */