summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJerry Lee <jerrylee@qnap.com>2017-08-06 07:18:31 +0200
committerTheodore Ts'o <tytso@mit.edu>2017-08-06 07:18:31 +0200
commitaec51758ce10a9c847a62a48a168f8c804c6e053 (patch)
treea832c2ad23820173519a3cd79796636eafbe36e3
parentext4, project: expand inode extra size if possible (diff)
downloadlinux-aec51758ce10a9c847a62a48a168f8c804c6e053.tar.xz
linux-aec51758ce10a9c847a62a48a168f8c804c6e053.zip
ext4: fix overflow caused by missing cast in ext4_resize_fs()
On a 32-bit platform, the value of n_blcoks_count may be wrong during the file system is resized to size larger than 2^32 blocks. This may caused the superblock being corrupted with zero blocks count. Fixes: 1c6bd7173d66 Signed-off-by: Jerry Lee <jerrylee@qnap.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Cc: stable@vger.kernel.org # 3.7+
-rw-r--r--fs/ext4/resize.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index c3ed9021b781..035cd3f4785e 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -1927,7 +1927,8 @@ retry:
n_desc_blocks = o_desc_blocks +
le16_to_cpu(es->s_reserved_gdt_blocks);
n_group = n_desc_blocks * EXT4_DESC_PER_BLOCK(sb);
- n_blocks_count = n_group * EXT4_BLOCKS_PER_GROUP(sb);
+ n_blocks_count = (ext4_fsblk_t)n_group *
+ EXT4_BLOCKS_PER_GROUP(sb);
n_group--; /* set to last group number */
}