diff options
| author | Jacek Anaszewski <j.anaszewski@samsung.com> | 2015-11-25 09:22:19 +0100 |
|---|---|---|
| committer | Jacek Anaszewski <j.anaszewski@samsung.com> | 2016-01-04 09:57:38 +0100 |
| commit | 0c24199ca9dd0ec1eaddc49ec83ca97bc1f1c233 (patch) | |
| tree | 0ff0739bc9d4758459b4e71b86d820a2ad6be94f | |
| parent | leds: powernv: Implement brightness_set_blocking op (diff) | |
| download | linux-0c24199ca9dd0ec1eaddc49ec83ca97bc1f1c233.tar.xz linux-0c24199ca9dd0ec1eaddc49ec83ca97bc1f1c233.zip | |
leds: aat1290: Add missing of_node_put
The refcount of device_node increases after of_get_next_available_child()
is called. Make sure it is decremented also in case of DT parsing error.
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
| -rw-r--r-- | drivers/leds/leds-aat1290.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c index f2259308b92e..def3cf9f7e92 100644 --- a/drivers/leds/leds-aat1290.c +++ b/drivers/leds/leds-aat1290.c @@ -275,7 +275,7 @@ static int aat1290_led_parse_dt(struct aat1290_led *led, if (ret < 0) { dev_err(dev, "flash-max-microamp DT property missing\n"); - return ret; + goto err_parse_dt; } ret = of_property_read_u32(child_node, "flash-max-timeout-us", @@ -283,13 +283,14 @@ static int aat1290_led_parse_dt(struct aat1290_led *led, if (ret < 0) { dev_err(dev, "flash-max-timeout-us DT property missing\n"); - return ret; + goto err_parse_dt; } - of_node_put(child_node); - *sub_node = child_node; +err_parse_dt: + of_node_put(child_node); + return ret; } |