summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexey Obitotskiy <aleksey.obitotskiy@intel.com>2016-06-23 12:11:01 +0200
committerShaohua Li <shli@fb.com>2016-07-19 20:17:31 +0200
commit4cb9da7d9c631514effa5e806f9de7c7c746c3a8 (patch)
tree077f8129fd8276ec965e537326b53bea2d2bfeec
parentmd: use seconds granularity for error logging (diff)
downloadlinux-4cb9da7d9c631514effa5e806f9de7c7c746c3a8.tar.xz
linux-4cb9da7d9c631514effa5e806f9de7c7c746c3a8.zip
Fix kernel module refcount handling
md loads raidX modules and increments module refcount each time level has changed but does not decrement it. You are unable to unload raid0 module after reshape because raid0 reshape changes level to raid4 and back to raid0. Signed-off-by: Aleksey Obitotskiy <aleksey.obitotskiy@intel.com> Signed-off-by: Shaohua Li <shli@fb.com>
-rw-r--r--drivers/md/md.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 4b8a264e9777..29297e97cdea 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3579,6 +3579,8 @@ level_store(struct mddev *mddev, const char *buf, size_t len)
mddev->to_remove = &md_redundancy_group;
}
+ module_put(oldpers->owner);
+
rdev_for_each(rdev, mddev) {
if (rdev->raid_disk < 0)
continue;