diff options
| author | Julia Lawall <julia@diku.dk> | 2010-03-29 07:35:05 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-03-31 08:03:18 +0200 |
| commit | ce6fbdefb68d46db88170494b277551f955b48e2 (patch) | |
| tree | 518b920f15c6cb00717767b521f3f596babfe34d | |
| parent | net: gianfar - align BD ring size console messages (diff) | |
| download | linux-ce6fbdefb68d46db88170494b277551f955b48e2.tar.xz linux-ce6fbdefb68d46db88170494b277551f955b48e2.zip | |
drivers/net: Add missing unlock
Unlock the lock before leaving the function.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
expression E1;
identifier f;
@@
f (...) { <+...
* spin_lock_irqsave (E1,...);
... when != E1
* return ...;
...+> }
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/sgiseeq.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/sgiseeq.c b/drivers/net/sgiseeq.c index ed999d31f1fa..37f6a00cde17 100644 --- a/drivers/net/sgiseeq.c +++ b/drivers/net/sgiseeq.c @@ -592,8 +592,10 @@ static int sgiseeq_start_xmit(struct sk_buff *skb, struct net_device *dev) /* Setup... */ len = skb->len; if (len < ETH_ZLEN) { - if (skb_padto(skb, ETH_ZLEN)) + if (skb_padto(skb, ETH_ZLEN)) { + spin_unlock_irqrestore(&sp->tx_lock, flags); return NETDEV_TX_OK; + } len = ETH_ZLEN; } |