diff options
| author | Trond Myklebust <trond.myklebust@primarydata.com> | 2016-01-21 21:39:40 +0100 |
|---|---|---|
| committer | Trond Myklebust <trond.myklebust@primarydata.com> | 2016-01-22 17:01:44 +0100 |
| commit | 082fa37d1351a41afc491d44a1d095cb8d919aa2 (patch) | |
| tree | 91a373c37d5d3b4c3751f1aaf3974dda1cf237ce | |
| parent | pNFS/flexfiles: Improve merging of errors in LAYOUTRETURN (diff) | |
| download | linux-082fa37d1351a41afc491d44a1d095cb8d919aa2.tar.xz linux-082fa37d1351a41afc491d44a1d095cb8d919aa2.zip | |
pNFS/flexfiles: Fix an XDR encoding bug in layoutreturn
We must not skip encoding the statistics, or the server will see an
XDR encoding error.
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: stable@vger.kernel.org # 4.0+
| -rw-r--r-- | fs/nfs/flexfilelayout/flexfilelayout.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/nfs/flexfilelayout/flexfilelayout.c b/fs/nfs/flexfilelayout/flexfilelayout.c index 405f46ba490e..2a2e2d8ddee5 100644 --- a/fs/nfs/flexfilelayout/flexfilelayout.c +++ b/fs/nfs/flexfilelayout/flexfilelayout.c @@ -1859,11 +1859,9 @@ ff_layout_encode_layoutreturn(struct pnfs_layout_hdr *lo, start = xdr_reserve_space(xdr, 4); BUG_ON(!start); - if (ff_layout_encode_ioerr(flo, xdr, args)) - goto out; - + ff_layout_encode_ioerr(flo, xdr, args); ff_layout_encode_iostats(flo, xdr, args); -out: + *start = cpu_to_be32((xdr->p - start - 1) * 4); dprintk("%s: Return\n", __func__); } |