diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-06-06 23:41:40 +0200 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@redhat.com> | 2012-07-25 21:06:20 +0200 |
| commit | b08f5bc40424a3c4b4c884257441141b23cfa795 (patch) | |
| tree | 9a4f5fcfe3531db8585d9d1b822f79e38574b370 | |
| parent | pata_imx: Convert to clk_prepare_enable/clk_disable_unprepare (diff) | |
| download | linux-b08f5bc40424a3c4b4c884257441141b23cfa795.tar.xz linux-b08f5bc40424a3c4b4c884257441141b23cfa795.zip | |
drivers/ata/pata_pcmcia.c: adjust suspicious bit operation
IO_DATA_PATH_WIDTH_8 is 0, so a bit-and with it is always false. The
value IO_DATA_PATH_WIDTH covers the bits of the IO_DATA_PATH constants, so
first pick those bits and then make the test using !=.
This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
| -rw-r--r-- | drivers/ata/pata_pcmcia.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/ata/pata_pcmcia.c b/drivers/ata/pata_pcmcia.c index a808ba03bd7f..958238dda8fc 100644 --- a/drivers/ata/pata_pcmcia.c +++ b/drivers/ata/pata_pcmcia.c @@ -170,7 +170,8 @@ static int pcmcia_check_one_config(struct pcmcia_device *pdev, void *priv_data) { int *is_kme = priv_data; - if (!(pdev->resource[0]->flags & IO_DATA_PATH_WIDTH_8)) { + if ((pdev->resource[0]->flags & IO_DATA_PATH_WIDTH) + != IO_DATA_PATH_WIDTH_8) { pdev->resource[0]->flags &= ~IO_DATA_PATH_WIDTH; pdev->resource[0]->flags |= IO_DATA_PATH_WIDTH_AUTO; } |