diff options
| author | Julia Lawall <julia@diku.dk> | 2010-05-28 01:29:05 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-05-28 10:57:18 +0200 |
| commit | 89dc0be68f4aaa06dba1b5d6ea9ecfe8fa9b7bf0 (patch) | |
| tree | aededffd13259b3d9b76a423fd98b811327e9597 | |
| parent | be2net: Patch removes redundant while statement in loop. (diff) | |
| download | linux-89dc0be68f4aaa06dba1b5d6ea9ecfe8fa9b7bf0.tar.xz linux-89dc0be68f4aaa06dba1b5d6ea9ecfe8fa9b7bf0.zip | |
drivers/net/hamradio: Eliminate a NULL pointer dereference
At the point of the print, dev is NULL.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
expression E,E1;
identifier f;
statement S1,S2,S3;
@@
if ((E == NULL && ...) || ...)
{
... when != if (...) S1 else S2
when != E = E1
* E->f
... when any
return ...;
}
else S3
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/hamradio/yam.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c index 694132e04af6..4e7d1d0a2340 100644 --- a/drivers/net/hamradio/yam.c +++ b/drivers/net/hamradio/yam.c @@ -1151,8 +1151,7 @@ static int __init yam_init_driver(void) dev = alloc_netdev(sizeof(struct yam_port), name, yam_setup); if (!dev) { - printk(KERN_ERR "yam: cannot allocate net device %s\n", - dev->name); + pr_err("yam: cannot allocate net device\n"); err = -ENOMEM; goto error; } |