diff options
| author | Sonic Zhang <sonic.zhang@analog.com> | 2008-11-18 10:48:22 +0100 |
|---|---|---|
| committer | Bryan Wu <cooloney@kernel.org> | 2008-11-18 10:48:22 +0100 |
| commit | 8a0e9acfd153cf5c726f010b075a3d4d55f80895 (patch) | |
| tree | 8ba08c1f2ae8c13130ea1894035ffd42fa691a09 | |
| parent | Blackfin arch: fix unused warning for some blackfin derivatives (diff) | |
| download | linux-8a0e9acfd153cf5c726f010b075a3d4d55f80895.tar.xz linux-8a0e9acfd153cf5c726f010b075a3d4d55f80895.zip | |
Blackfin arch: Fix bug - hardware breakpoint doesn't always work in kgdb
Hardware breakpoint doesn't always work in kgdb. It works at the first
two times, but if you repeatedly trigger that hardware breakpoint, it
would slip over that point once in two times.
Fix it by always setting hw bp skip to 0. gdb does skip after hw bp trap.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
| -rw-r--r-- | arch/blackfin/kernel/kgdb.c | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/arch/blackfin/kernel/kgdb.c b/arch/blackfin/kernel/kgdb.c index ab4022131a2a..0c4c53fa723e 100644 --- a/arch/blackfin/kernel/kgdb.c +++ b/arch/blackfin/kernel/kgdb.c @@ -219,6 +219,7 @@ int bfin_set_hw_break(unsigned long addr, int len, enum kgdb_bptype type) if (bfin_type == breakinfo[breakno].type && !breakinfo[breakno].occupied) { breakinfo[breakno].occupied = 1; + breakinfo[breakno].skip = 0; breakinfo[breakno].enabled = 1; breakinfo[breakno].addr = addr; breakinfo[breakno].dataacc = dataacc; @@ -426,17 +427,6 @@ int kgdb_arch_handle_exception(int vector, int signo, kgdb_single_step = i + 1; } - if (vector == VEC_WATCH) { - wp_status = bfin_read_WPSTAT(); - for (breakno = 0; breakno < HW_WATCHPOINT_NUM; breakno++) { - if (wp_status & (1 << breakno)) { - breakinfo->skip = 1; - break; - } - } - bfin_write_WPSTAT(0); - } - bfin_correct_hw_break(); return 0; |